[ARVADOS] created: deb14a7264ed4a07d154504991447c3be8413db7

[Git user]

        at  deb14a7264ed4a07d154504991447c3be8413db7 (commit)


commit deb14a7264ed4a07d154504991447c3be8413db7
Author: Tom Clegg <tclegg at veritasgenetics.com>
Date:   Wed Sep 27 11:26:22 2017 -0400

    12246: Add debugging clues when command is not found in container.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg at veritasgenetics.com>

diff --git a/services/crunch-run/crunchrun.go b/services/crunch-run/crunchrun.go
index 27bfa88..080a0fc 100644
--- a/services/crunch-run/crunchrun.go
+++ b/services/crunch-run/crunchrun.go
@@ -857,7 +857,11 @@ func (runner *ContainerRunner) StartContainer() error {
 	err := runner.Docker.ContainerStart(context.TODO(), runner.ContainerID,
 		dockertypes.ContainerStartOptions{})
 	if err != nil {
-		return fmt.Errorf("could not start container: %v", err)
+		var advice string
+		if strings.Contains(err.Error(), "no such file or directory") {
+			advice = fmt.Sprintf(" (perhaps command %q is missing, or has a missing #! interpreter, or was saved in DOS mode with cr-lf chars?)", runner.Container.Command[0])
+		}
+		return fmt.Errorf("could not start container%s: %v", advice, err)
 	}
 	runner.cStarted = true
 	return nil

-----------------------------------------------------------------------


hooks/post-receive
--