[ARVADOS] updated: e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353

Git user git at public.curoverse.com
Fri Jun 30 15:39:54 EDT 2017


Summary of changes:
 apps/workbench/test/integration/collection_upload_test.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

       via  e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353 (commit)
      from  1b8d669706fb952f0e5d1ad5e407073f4815907f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353
Author: Tom Clegg <tom at curoverse.com>
Date:   Fri Jun 30 15:34:08 2017 -0400

    8784: Fix test for latest firefox.
    
    Given "http://host:99999/path", Firefox 54 returns an error
    "SyntaxError: The URI is malformed" instead of trying to connect to
    port 99999 and returning a network error. Changing 99999 to 0 produces
    the try-and-fail behavior we want to test.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at curoverse.com>

diff --git a/apps/workbench/test/integration/collection_upload_test.rb b/apps/workbench/test/integration/collection_upload_test.rb
index 552a9cd..f2a638f 100644
--- a/apps/workbench/test/integration/collection_upload_test.rb
+++ b/apps/workbench/test/integration/collection_upload_test.rb
@@ -92,11 +92,11 @@ class CollectionUploadTest < ActionDispatch::IntegrationTest
   test "Report network error" do
     need_selenium "to make file uploads work"
     use_token :admin do
-      # Even if you somehow do port>2^16, surely nx.example.net won't
+      # Even if port 0 is a thing, surely nx.example.net won't
       # respond
       KeepService.where(service_type: 'proxy').first.
         update_attributes(service_host: 'nx.example.net',
-                          service_port: 99999)
+                          service_port: 0)
     end
     visit page_with_token 'active', sandbox_path
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list