[ARVADOS] updated: 5d03f6499055ef109ca2c8d5d59941b25de1fa47

Git user git at public.curoverse.com
Fri Jun 2 15:45:56 EDT 2017


Summary of changes:
 services/api/app/controllers/arvados/v1/keep_services_controller.rb | 1 +
 .../api/test/functional/arvados/v1/keep_services_controller_test.rb | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

       via  5d03f6499055ef109ca2c8d5d59941b25de1fa47 (commit)
      from  0f5295ae31362eefe182f3a2329b3903d6f82a3b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 5d03f6499055ef109ca2c8d5d59941b25de1fa47
Author: Tom Clegg <tom at curoverse.com>
Date:   Fri Jun 2 15:43:28 2017 -0400

    9005: Serve keep_services/accessible regardless of auth status.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at curoverse.com>

diff --git a/services/api/app/controllers/arvados/v1/keep_services_controller.rb b/services/api/app/controllers/arvados/v1/keep_services_controller.rb
index d2a512b..e59c5f2 100644
--- a/services/api/app/controllers/arvados/v1/keep_services_controller.rb
+++ b/services/api/app/controllers/arvados/v1/keep_services_controller.rb
@@ -2,6 +2,7 @@ class Arvados::V1::KeepServicesController < ApplicationController
 
   skip_before_filter :find_object_by_uuid, only: :accessible
   skip_before_filter :render_404_if_no_object, only: :accessible
+  skip_before_filter :require_auth_scope, only: :accessible
 
   def find_objects_for_index
     # all users can list all keep services
diff --git a/services/api/test/functional/arvados/v1/keep_services_controller_test.rb b/services/api/test/functional/arvados/v1/keep_services_controller_test.rb
index 1375d4c..706f73f 100644
--- a/services/api/test/functional/arvados/v1/keep_services_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/keep_services_controller_test.rb
@@ -20,9 +20,9 @@ class Arvados::V1::KeepServicesControllerTest < ActionController::TestCase
     assert_equal true, assigns(:objects).any?
   end
 
-  [:admin, :active, :inactive, :anonymous].each do |u|
-    test "accessible to #{u} user" do
-      authorize_with u
+  [:admin, :active, :inactive, :anonymous, nil].each do |u|
+    test "accessible to #{u.inspect} user" do
+      authorize_with(u) if u
       get :accessible
       assert_response :success
       assert_not_empty json_response['items']

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list