[ARVADOS] created: e914c48b16e6bb8199ebad89096a09e477a7efe8

[Git user]

        at  e914c48b16e6bb8199ebad89096a09e477a7efe8 (commit)


commit e914c48b16e6bb8199ebad89096a09e477a7efe8
Author: Tom Clegg <tom at curoverse.com>
Date:   Wed Jul 5 17:34:11 2017 -0400

    11927: Eliminate unnecessary use of selenium.
    
    This test case works without selenium, if we don't try to click an
    "edit" link that's disabled because we already clicked it.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at curoverse.com>

diff --git a/apps/workbench/test/integration/collections_test.rb b/apps/workbench/test/integration/collections_test.rb
index af8e131..8619858 100644
--- a/apps/workbench/test/integration/collections_test.rb
+++ b/apps/workbench/test/integration/collections_test.rb
@@ -426,8 +426,6 @@ class CollectionsTest < ActionDispatch::IntegrationTest
   end
 
   test "collection tags tab" do
-    need_selenium
-
     visit page_with_token('active', '/collections/zzzzz-4zz18-bv31uwvy3neko21')
 
     click_link 'Tags'
@@ -447,8 +445,6 @@ class CollectionsTest < ActionDispatch::IntegrationTest
     assert_selector 'a', text: 'Cancel'
 
     # add two tags
-    first('.edit-collection-tags').click
-
     first('.glyphicon-plus').click
     first('.collection-tag-field-key').click
     first('.collection-tag-field-key').set('key 1')

commit 7d751b9d0966b6e0ed544fe4d69f58511c14842f
Author: Tom Clegg <tom at curoverse.com>
Date:   Wed Jul 5 17:30:28 2017 -0400

    11927: Remove errant type attr from anchor element.
    
    Anchor elements do have a "type" attribute, but it specifies a MIME
    type, not a data/control type like "button" as with input elements.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at curoverse.com>

diff --git a/apps/workbench/app/views/collections/_show_tags.html.erb b/apps/workbench/app/views/collections/_show_tags.html.erb
index fd734c8..afab526 100644
--- a/apps/workbench/app/views/collections/_show_tags.html.erb
+++ b/apps/workbench/app/views/collections/_show_tags.html.erb
@@ -9,7 +9,7 @@ SPDX-License-Identifier: AGPL-3.0 %>
   <div class="collection-tags-container" style="padding-left:2em;padding-right:2em;">
     <% if object.editable? %>
       <p title="Edit tags" id="edit-collection-tags">
-        <a type="button" class="btn btn-primary edit-collection-tags">Edit</a>
+        <a class="btn btn-primary edit-collection-tags">Edit</a>
       </p>
     <% end %>
 

-----------------------------------------------------------------------


hooks/post-receive
--