[ARVADOS] updated: fe1b0b43931dcefbf9308dc7b0a3639a4410ca53

Git user git at public.curoverse.com
Wed Jan 11 16:25:12 EST 2017


Summary of changes:
 services/api/app/models/user.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

       via  fe1b0b43931dcefbf9308dc7b0a3639a4410ca53 (commit)
      from  87275ec769831e04982a714049ee9d67b6342d68 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit fe1b0b43931dcefbf9308dc7b0a3639a4410ca53
Author: Tom Clegg <tom at curoverse.com>
Date:   Wed Jan 11 16:13:05 2017 -0500

    10816: Add comments to poorly-documented name/binds args to exec_query().

diff --git a/services/api/app/models/user.rb b/services/api/app/models/user.rb
index eb181c3..78ec7be 100644
--- a/services/api/app/models/user.rb
+++ b/services/api/app/models/user.rb
@@ -166,8 +166,11 @@ class User < ArvadosModel
                     WHERE user_uuid = $1
                     AND target_owner_uuid IS NOT NULL
                     GROUP BY target_owner_uuid',
+                    # "name" arg is a query label that appears in logs:
                     "group_permissions for #{uuid}",
-                    [[nil, uuid]]).rows.each do |group_uuid, max_p_val|
+                    # "binds" arg is an array of [col_id, value] for '$1' vars:
+                    [[nil, uuid]],
+                    ).rows.each do |group_uuid, max_p_val|
       group_perms[group_uuid] = PERMS_FOR_VAL[max_p_val.to_i]
     end
     Rails.cache.write "groups_for_user_#{self.uuid}", group_perms

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list