[ARVADOS] updated: 6284bed37f6b2bb3c0671b401aa0d99d5ef7a5b7

Git user git at public.curoverse.com
Wed Sep 14 11:38:17 EDT 2016


Summary of changes:
 .../app/controllers/work_units_controller.rb       |  8 +--
 apps/workbench/app/models/pipeline_instance.rb     |  2 +-
 .../test/controllers/workflows_controller_test.rb  |  2 +-
 build/run-build-docker-jobs-image.sh               |  6 +-
 build/run-build-packages.sh                        |  2 +-
 doc/_config.yml                                    |  6 ++
 .../_container_runtime_constraints.liquid          |  9 +++
 doc/_includes/_mount_types.liquid                  | 63 ++++++++++++++++++
 .../methods/container_requests.html.textile.liquid | 74 ++++++++++++++++++++++
 ...xtile.liquid => containers.html.textile.liquid} | 48 +++++++-------
 ...extile.liquid => workflows.html.textile.liquid} | 30 ++++-----
 doc/api/schema/Container.html.textile.liquid       | 59 +++++++++++++++++
 .../schema/ContainerRequest.html.textile.liquid    | 50 +++++++++++++++
 doc/api/schema/Workflow.html.textile.liquid        | 23 +++++++
 sdk/cli/bin/crunch-job                             | 42 +++++++++++-
 sdk/cwl/arvados_cwl/__init__.py                    |  4 +-
 sdk/cwl/arvados_cwl/arvworkflow.py                 |  4 +-
 sdk/cwl/setup.py                                   |  2 +-
 sdk/cwl/tests/test_submit.py                       |  2 +-
 sdk/go/dispatch/dispatch.go                        | 20 +++++-
 .../arvados/v1/containers_controller.rb            | 10 +++
 services/api/app/models/arvados_model.rb           |  8 ++-
 services/api/app/models/container.rb               | 20 ++++++
 services/api/app/models/workflow.rb                | 14 ++--
 services/api/config/routes.rb                      |  2 +
 ...20160909181442_rename_workflow_to_definition.rb | 10 +++
 services/api/db/structure.sql                      |  8 ++-
 services/api/test/fixtures/container_requests.yml  |  5 +-
 services/api/test/fixtures/containers.yml          |  1 +
 services/api/test/fixtures/jobs.yml                |  6 +-
 services/api/test/fixtures/workflows.yml           | 16 ++---
 .../arvados/v1/containers_controller_test.rb       | 44 ++++++++++++-
 .../functional/arvados/v1/jobs_controller_test.rb  |  2 +-
 services/api/test/unit/container_test.rb           | 24 +++----
 services/api/test/unit/job_test.rb                 | 22 +++++++
 services/api/test/unit/workflow_test.rb            | 66 +++++++++----------
 .../crunch-dispatch-local_test.go                  |  8 ++-
 .../crunch-dispatch-slurm/crunch-dispatch-slurm.go | 21 +++---
 services/keep-balance/balance.go                   | 19 +++---
 39 files changed, 611 insertions(+), 151 deletions(-)
 create mode 100644 doc/_includes/_container_runtime_constraints.liquid
 create mode 100644 doc/_includes/_mount_types.liquid
 create mode 100644 doc/api/methods/container_requests.html.textile.liquid
 copy doc/api/methods/{nodes.html.textile.liquid => containers.html.textile.liquid} (51%)
 copy doc/api/methods/{specimens.html.textile.liquid => workflows.html.textile.liquid} (59%)
 create mode 100644 doc/api/schema/Container.html.textile.liquid
 create mode 100644 doc/api/schema/ContainerRequest.html.textile.liquid
 create mode 100644 doc/api/schema/Workflow.html.textile.liquid
 create mode 100644 services/api/db/migrate/20160909181442_rename_workflow_to_definition.rb

       via  6284bed37f6b2bb3c0671b401aa0d99d5ef7a5b7 (commit)
       via  1a87c77a5cfe200921a9d09e995383bc675e7370 (commit)
       via  05428b719b804e68a17e07af0de00c0607d0be04 (commit)
       via  0b19ca02c8387ff1eda4ccafb9bd0fda7b79c3b1 (commit)
       via  39c12f4da6dcdbfa1a4232dc849d303692dfb401 (commit)
       via  adfe146695a6acebe65b7953db1e8a88dc53a6b4 (commit)
       via  a61c6238265db896c91902f27f692f98f780393c (commit)
       via  ae71ca7f426bfb59e154350370c96cc2b31d6e0d (commit)
       via  4a46faf1f480ab6d40389be752f56bcda3581b2e (commit)
       via  e8db2a47dd834640eeafeb7fa6741d725c1fac9c (commit)
       via  50b696969d71739e9fd083664de6a81db7e211b3 (commit)
       via  a673edc3450f2acee47e811a6197a6eb087ee275 (commit)
       via  faf5328304cd7c0b3ec1669c6f7f18c3f4daf25c (commit)
       via  f82ee19a440e31f05381511cf6c0d7932d804b9d (commit)
       via  c0d988e71f9657d0dea5a36c6b9904e1688e2448 (commit)
       via  b54478ea1b7c8aaeaf565d591f32769bcdc09b8f (commit)
       via  e51906ca834222fa0e85d01568507a39af4fde36 (commit)
       via  e636f4ec762410391aa8df7502468f98612ebb42 (commit)
       via  19ad5c59b064088c58136f5387fdf029b754ee36 (commit)
       via  882be2b6f0e2b45e282cf584cf14e5dccc4b5b9a (commit)
       via  d51c716d0d547ecea25819678c6e50b647051da9 (commit)
       via  2d392cf1c0726dcde178199fdafc094ee62a954a (commit)
       via  b758d48df3373a401cef74b0c8c99f918918afee (commit)
       via  f00a2304c3668e74c6ab53e27793166b02b709d2 (commit)
       via  7c335bf3dc935f6ac0f1845f65063d5b40ddb5ed (commit)
       via  23bfb867e544d4c470802ca775da593779bffdc1 (commit)
       via  7846843453df9846c346f85c20a8d6d051066f52 (commit)
       via  07ad9aa37c3b907adf85821a192041b5bb478fec (commit)
       via  795125d3d998bc1fdbaf31d7d3dd048564f8e685 (commit)
       via  9bad58fd3334bab5c9a09f365912a37c5f63fcdc (commit)
       via  706abfc3fe0788584d930ae2297b2b01dab8cf36 (commit)
       via  cdc4b9c4561f09b4cfb59f4b61689a661823ad85 (commit)
       via  8eaed3be04eb6356920b764f8ae370ddf8ace94c (commit)
       via  5afa718bbfbe9cded6a852af216788629c3afc72 (commit)
       via  c0650d1d845b08668445fa5245d0e532b38afb95 (commit)
       via  15a9dff29d3e5c16d936650c16b498fba1002860 (commit)
       via  934694fb672f0768ec61701009a4eb2e149d6431 (commit)
       via  cc13854bd4675d9f1de807c38dfada0315bf3291 (commit)
       via  e378ed1d86cbab36f0c7093e4dc189f6184834bf (commit)
       via  769189c406bb42761f4d7bfe35fd2cc36edcef00 (commit)
       via  3ea8a43af615fc16cb8884a7bda78093c449542c (commit)
       via  feaf44094afa6774cd6583f1a121454d6754ba0c (commit)
       via  5054334a7417e35990e020aecf852a5eb3056108 (commit)
       via  67afdf7bd1d53164e91e38e3b3a801ae83da778d (commit)
       via  716fc68b444bb4d43ecad56bcb90e9ebf4bda854 (commit)
      from  2b50a5838d80dc6e93864a0b8180b423497a8e1d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 6284bed37f6b2bb3c0671b401aa0d99d5ef7a5b7
Author: Peter Amstutz <peter.amstutz at curoverse.com>
Date:   Wed Sep 14 11:38:13 2016 -0400

    9766: Rename metavar.  Post packed yaml text instead of json.  Adjust fixture
    to have similar form as posted by --create-workflow.  Fix fixture to be a
    string instead of structured text.

diff --git a/sdk/cwl/arvados_cwl/__init__.py b/sdk/cwl/arvados_cwl/__init__.py
index b11ca54..309e941 100644
--- a/sdk/cwl/arvados_cwl/__init__.py
+++ b/sdk/cwl/arvados_cwl/__init__.py
@@ -329,7 +329,7 @@ def arg_parser():  # type: () -> argparse.ArgumentParser
                         default=True, dest="enable_reuse",
                         help="")
 
-    parser.add_argument("--project-uuid", type=str, help="Project that will own the workflow jobs, if not provided, will go to home project.")
+    parser.add_argument("--project-uuid", type=str, metavar="UUID", help="Project that will own the workflow jobs, if not provided, will go to home project.")
     parser.add_argument("--ignore-docker-for-reuse", action="store_true",
                         help="Ignore Docker image version when deciding whether to reuse past jobs.",
                         default=False)
@@ -341,7 +341,7 @@ def arg_parser():  # type: () -> argparse.ArgumentParser
                         default=True, dest="submit")
     exgroup.add_argument("--create-template", action="store_true", help="Create an Arvados pipeline template.")
     exgroup.add_argument("--create-workflow", action="store_true", help="Create an Arvados workflow.")
-    exgroup.add_argument("--update-workflow", type=str, help="Update Arvados workflow.")
+    exgroup.add_argument("--update-workflow", type=str, metavar="UUID", help="Update existing Arvados workflow with uuid.")
 
     exgroup = parser.add_mutually_exclusive_group()
     exgroup.add_argument("--wait", action="store_true", help="After submitting workflow runner job, wait for completion.",
diff --git a/sdk/cwl/arvados_cwl/arvworkflow.py b/sdk/cwl/arvados_cwl/arvworkflow.py
index fb14ab4..37a0540 100644
--- a/sdk/cwl/arvados_cwl/arvworkflow.py
+++ b/sdk/cwl/arvados_cwl/arvworkflow.py
@@ -6,6 +6,8 @@ from cwltool.pack import pack
 from cwltool.load_tool import fetch_document
 from cwltool.process import shortname
 
+import ruamel.yaml as yaml
+
 from .runner import upload_docker, upload_dependencies
 
 def make_workflow(arvRunner, tool, job_order, project_uuid, update_uuid):
@@ -30,7 +32,7 @@ def make_workflow(arvRunner, tool, job_order, project_uuid, update_uuid):
             "owner_uuid": project_uuid,
             "name": tool.tool.get("label", name),
             "description": tool.tool.get("doc", ""),
-            "workflow":json.dumps(packed, sort_keys=True, indent=4, separators=(',',': '))
+            "definition":yaml.safe_dump(packed)
         }}
 
     if update_uuid:
diff --git a/sdk/cwl/tests/test_submit.py b/sdk/cwl/tests/test_submit.py
index ddb9e46..b8d2a55 100644
--- a/sdk/cwl/tests/test_submit.py
+++ b/sdk/cwl/tests/test_submit.py
@@ -306,7 +306,7 @@ class TestCreateWorkflow(unittest.TestCase):
                 "owner_uuid": project_uuid,
                 "name": "submit_wf.cwl",
                 "description": "",
-                "workflow": expect_workflow
+                "definition": expect_workflow
                 }
         }
         stubs.api.workflows().create.assert_called_with(
diff --git a/services/api/test/fixtures/container_requests.yml b/services/api/test/fixtures/container_requests.yml
index dcaf657..49a1fae 100644
--- a/services/api/test/fixtures/container_requests.yml
+++ b/services/api/test/fixtures/container_requests.yml
@@ -209,6 +209,8 @@ uncommitted:
             "kind": "json",
             "content": {
                 "cwlVersion": "v1.0",
+                "$graph": [{
+                "id": "#main",
                 "class": "CommandLineTool",
                 "baseCommand": ["echo"],
                 "inputs": [
@@ -289,7 +291,8 @@ uncommitted:
                     }
                 ],
                 "outputs": []
-            }
+            }]
+          }
         },
         "/var/lib/cwl/cwl.input.json": {
             "kind": "json",
diff --git a/services/api/test/fixtures/workflows.yml b/services/api/test/fixtures/workflows.yml
index 4e1f4af..4badf9e 100644
--- a/services/api/test/fixtures/workflows.yml
+++ b/services/api/test/fixtures/workflows.yml
@@ -25,7 +25,7 @@ workflow_with_input_specifications:
   name: Workflow with input specifications
   description: this workflow has inputs specified
   created_at: <%= 1.minute.ago.to_s(:db) %>
-  definition:
+  definition: |
     cwlVersion: v1.0
     class: CommandLineTool
     baseCommand:

commit 1a87c77a5cfe200921a9d09e995383bc675e7370
Merge: 2b50a58 05428b7
Author: Peter Amstutz <peter.amstutz at curoverse.com>
Date:   Wed Sep 14 08:35:15 2016 -0400

    Merge branch 'master' into 9766-register-workflow


-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list