Summary of changes:
services/fuse/arvados_fuse/__init__.py | 14 +++++++
services/fuse/tests/integration_test.py | 1 -
services/fuse/tests/test_mount.py | 34 ----------------
services/fuse/tests/test_token_expiry.py | 68 ++++++++++++++++++++++++++++++++
4 files changed, 82 insertions(+), 35 deletions(-)
create mode 100644 services/fuse/tests/test_token_expiry.py
via 0066dc77abc461090fe98bcee7c6e324a5ca43a1 (commit)
via 07b6eaeada7c10c3efb9b917579c474bd66685b0 (commit)
via 7bf89e17945bb6610d6339409a6a411803851434 (commit)
via b73985d8a0c9173aec57f6a81fe540b2813a5bff (commit)
via dfe0ec7bfec3fd72cd40d3962e5c8af08d2413d2 (commit)
via 6349237efb19ca7fcad94333090d694fda3d4374 (commit)
via ed16f0c1f600acd7bab81796ec22fde90ecdfa7f (commit)
via 17f2b714df870dffc6320173d6a2348243ff7992 (commit)
from 40cad1b6c6b969c78fb415ee7be59dac32c45891 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 0066dc77abc461090fe98bcee7c6e324a5ca43a1
Merge: 40cad1b 07b6eae
Author: Tom Clegg <tom at curoverse.com>
Date: Wed Oct 26 11:40:42 2016 -0400
Merge branch '10008-check-token-exp-on-open' refs #10008
commit 07b6eaeada7c10c3efb9b917579c474bd66685b0
Author: Tom Clegg <tom at curoverse.com>
Date: Wed Oct 26 11:13:10 2016 -0400
10008: Comment to explain known deficiencies.
diff --git a/services/fuse/tests/test_token_expiry.py b/services/fuse/tests/test_token_expiry.py
index 415f9bb..e082e52 100644
--- a/services/fuse/tests/test_token_expiry.py
+++ b/services/fuse/tests/test_token_expiry.py
@@ -35,6 +35,11 @@ class TokenExpiryTest(IntegrationTest):
@mock.patch('arvados.keep.KeepClient.get')
@IntegrationTest.mount(argv=['--mount-by-id', 'zzz'])
def test_refresh_old_manifest(self, mocked_get, mocked_time, mocked_open):
+ # This test (and associated behavior) is still not strong
+ # enough. We should ensure old tokens are never used even if
+ # blobSignatureTtl seconds elapse between open() and
+ # read(). See https://dev.arvados.org/issues/10008
+
mocked_get.return_value = 'fake data'
mocked_time.side_effect = self.fake_time
mocked_open.side_effect = self.fake_open
-----------------------------------------------------------------------
hooks/post-receive
--