[ARVADOS] updated: 0c54a5c8b5d934cb3015234a41c3937b3d0fc3b9

Git user git at public.curoverse.com
Wed Nov 9 15:41:46 EST 2016


Summary of changes:
 sdk/cwl/arvados_cwl/arvjob.py | 2 ++
 sdk/cwl/arvados_cwl/runner.py | 3 +++
 2 files changed, 5 insertions(+)

       via  0c54a5c8b5d934cb3015234a41c3937b3d0fc3b9 (commit)
      from  287a03d273629ef15f77721ad2c7ce572fb5c078 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 0c54a5c8b5d934cb3015234a41c3937b3d0fc3b9
Author: Peter Amstutz <peter.amstutz at curoverse.com>
Date:   Tue Nov 8 17:15:19 2016 -0500

    10460: Add check for 'dockerOutputDirectory' and raise UnsupportedError for now.

diff --git a/sdk/cwl/arvados_cwl/arvjob.py b/sdk/cwl/arvados_cwl/arvjob.py
index 4336c0f..8a62204 100644
--- a/sdk/cwl/arvados_cwl/arvjob.py
+++ b/sdk/cwl/arvados_cwl/arvjob.py
@@ -85,6 +85,8 @@ class ArvadosJob(object):
         with Perf(metrics, "arv_docker_get_image %s" % self.name):
             (docker_req, docker_is_req) = get_feature(self, "DockerRequirement")
             if docker_req and kwargs.get("use_container") is not False:
+                if docker_req.get("dockerOutputDirectory"):
+                    raise UnsupportedRequirement("Option 'dockerOutputDirectory' of DockerRequirement not supported.")
                 runtime_constraints["docker_image"] = arv_docker_get_image(self.arvrunner.api, docker_req, pull_image, self.arvrunner.project_uuid)
             else:
                 runtime_constraints["docker_image"] = arvados_jobs_image(self.arvrunner)
diff --git a/sdk/cwl/arvados_cwl/runner.py b/sdk/cwl/arvados_cwl/runner.py
index ba41d7d..a114254 100644
--- a/sdk/cwl/arvados_cwl/runner.py
+++ b/sdk/cwl/arvados_cwl/runner.py
@@ -110,6 +110,9 @@ def upload_docker(arvrunner, tool):
     if isinstance(tool, CommandLineTool):
         (docker_req, docker_is_req) = get_feature(tool, "DockerRequirement")
         if docker_req:
+            if docker_req.get("dockerOutputDirectory"):
+                # TODO: can be supported by containers API, but not jobs API.
+                raise UnsupportedRequirement("Option 'dockerOutputDirectory' of DockerRequirement not supported.")
             arv_docker_get_image(arvrunner.api, docker_req, True, arvrunner.project_uuid)
     elif isinstance(tool, cwltool.workflow.Workflow):
         for s in tool.steps:

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list