[ARVADOS] updated: cd391613ae717c90ede24f220695c277ecd095ce

Git user git at public.curoverse.com
Mon Nov 7 15:44:24 EST 2016


Summary of changes:
 services/keepstore/s3_volume.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

  discards  e997c2308b00ba1864f13c506c6a8e86e01c83d8 (commit)
       via  cd391613ae717c90ede24f220695c277ecd095ce (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (e997c2308b00ba1864f13c506c6a8e86e01c83d8)
            \
             N -- N -- N (cd391613ae717c90ede24f220695c277ecd095ce)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit cd391613ae717c90ede24f220695c277ecd095ce
Author: Tom Clegg <tom at curoverse.com>
Date:   Mon Nov 7 15:44:20 2016 -0500

    10468: Use consts for defaults.

diff --git a/services/keepstore/s3_volume.go b/services/keepstore/s3_volume.go
index a0cf450..ed1161c 100644
--- a/services/keepstore/s3_volume.go
+++ b/services/keepstore/s3_volume.go
@@ -19,6 +19,11 @@ import (
 	"github.com/AdRoll/goamz/s3"
 )
 
+const (
+	s3DefaultReadTimeout    = arvados.Duration(10 * time.Minute)
+	s3DefaultConnectTimeout = arvados.Duration(time.Minute)
+)
+
 var (
 	// ErrS3TrashDisabled is returned by Trash if that operation
 	// is impossible with the current config.
@@ -213,10 +218,10 @@ func (v *S3Volume) Start() error {
 	// Zero timeouts mean "wait forever", which is a bad
 	// default. Default to long timeouts instead.
 	if v.ConnectTimeout == 0 {
-		v.ConnectTimeout = arvados.Duration(time.Minute)
+		v.ConnectTimeout = s3DefaultConnectTimeout
 	}
 	if v.ReadTimeout == 0 {
-		v.ReadTimeout = arvados.Duration(10 * time.Minute)
+		v.ReadTimeout = s3DefaultReadTimeout
 	}
 
 	client := s3.New(auth, region)

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list