[ARVADOS] updated: f6a485f2af3665d66d93621d3e0c40ee3e541eef

Git user git at public.curoverse.com
Tue Aug 23 16:39:34 EDT 2016


Summary of changes:
 apps/workbench/app/controllers/collections_controller.rb            | 4 ----
 apps/workbench/app/views/collections/show.html.erb                  | 6 +++---
 .../workbench/test/integration_performance/collections_perf_test.rb | 4 ++--
 3 files changed, 5 insertions(+), 9 deletions(-)

       via  f6a485f2af3665d66d93621d3e0c40ee3e541eef (commit)
      from  3f23d6fdf6fd1808249840a3635c1afe47726dfe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit f6a485f2af3665d66d93621d3e0c40ee3e541eef
Author: Lucas Di Pentima <lucas at curoverse.com>
Date:   Tue Aug 23 17:36:34 2016 -0300

    9804: Tweaked the collection#show's pane widths. Fixed some integration_performance tests that were failing after the activity pane removal and removed an unused query at collection controller.

diff --git a/apps/workbench/app/controllers/collections_controller.rb b/apps/workbench/app/controllers/collections_controller.rb
index 431c078..20b227c 100644
--- a/apps/workbench/app/controllers/collections_controller.rb
+++ b/apps/workbench/app/controllers/collections_controller.rb
@@ -253,10 +253,6 @@ class CollectionsController < ApplicationController
         @permissions = Link.limit(RELATION_LIMIT).order("modified_at DESC")
           .where(head_uuid: @object.uuid, link_class: 'permission',
                  name: 'can_read').results
-        @is_persistent = Link.limit(1)
-          .where(head_uuid: @object.uuid, tail_uuid: current_user.uuid,
-                 link_class: 'resources', name: 'wants')
-          .results.any?
         @search_sharing = search_scopes
 
         if params["tab_pane"] == "Used_by"
diff --git a/apps/workbench/app/views/collections/show.html.erb b/apps/workbench/app/views/collections/show.html.erb
index 663ae06..f0af963 100644
--- a/apps/workbench/app/views/collections/show.html.erb
+++ b/apps/workbench/app/views/collections/show.html.erb
@@ -1,5 +1,5 @@
 <div class="row row-fill-height">
-  <div class="col-md-6">
+  <div class="col-md-7">
     <div class="panel panel-info">
       <div class="panel-heading">
         <h3 class="panel-title">
@@ -28,7 +28,7 @@
     </div>
   </div>
   <% if current_user %>
-  <div class="col-md-6">
+  <div class="col-md-5">
     <div class="panel panel-default">
       <div class="panel-heading">
         <h3 class="panel-title">
@@ -68,7 +68,7 @@
     </div>
   </div>
   <% else %>
-  <div class="col-md-6">
+  <div class="col-md-5">
     <div class="panel panel-default">
       <div class="panel-heading">
         <h3 class="panel-title">
diff --git a/apps/workbench/test/integration_performance/collections_perf_test.rb b/apps/workbench/test/integration_performance/collections_perf_test.rb
index 3adece1..8b51b3f 100644
--- a/apps/workbench/test/integration_performance/collections_perf_test.rb
+++ b/apps/workbench/test/integration_performance/collections_perf_test.rb
@@ -42,7 +42,7 @@ class CollectionsPerfTest < ActionDispatch::IntegrationTest
       visit page_with_token('active', "/collections/#{new_collection.uuid}")
       Rails.logger.info "Done visiting collection at #{Time.now.to_f}"
 
-      assert_text new_collection.uuid
+      assert_selector "input[value=\"#{new_collection.uuid}\"]"
       assert(page.has_link?('collection_file_name_with_prefix_0'), "Collection page did not include file link")
     end
   end
@@ -62,7 +62,7 @@ class CollectionsPerfTest < ActionDispatch::IntegrationTest
       visit page_with_token('active', "/collections/#{new_collection.uuid}")
       Rails.logger.info "Done visiting collection at #{Time.now.to_f}"
 
-      assert_text new_collection.uuid
+      assert_selector "input[value=\"#{new_collection.uuid}\"]"
       assert(page.has_link?('collection_file_name_with_prefix_0'), "Collection page did not include file link")
 
       # edit description

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list