[ARVADOS] updated: 037735ad2e0637d1f1892847f0f82e255a1f764e

git at public.curoverse.com git at public.curoverse.com
Mon Sep 14 15:24:52 EDT 2015


Summary of changes:
 services/datamanager/collection/testing.go | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

       via  037735ad2e0637d1f1892847f0f82e255a1f764e (commit)
      from  c5eed3ffad31ff92f8399d32c57a710681c79caa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 037735ad2e0637d1f1892847f0f82e255a1f764e
Author: radhika <radhika at curoverse.com>
Date:   Mon Sep 14 15:23:56 2015 -0400

    6260: golint suggested updates

diff --git a/services/datamanager/collection/testing.go b/services/datamanager/collection/testing.go
index f3c1f47..ac6e9cb 100644
--- a/services/datamanager/collection/testing.go
+++ b/services/datamanager/collection/testing.go
@@ -7,6 +7,7 @@ import (
 	"git.curoverse.com/arvados.git/sdk/go/blockdigest"
 )
 
+// TestCollectionSpec with test blocks and desired replication level
 type TestCollectionSpec struct {
 	// The desired replication level
 	ReplicationLevel int
@@ -15,9 +16,9 @@ type TestCollectionSpec struct {
 	Blocks []int
 }
 
-// Creates a ReadCollections object for testing based on the give
-// specs.  Only the ReadAllCollections and UuidToCollection fields are
-// populated.  To populate other fields call rc.Summarize().
+// MakeTestReadCollections creates a ReadCollections object for testing
+// based on the give specs. Only the ReadAllCollections and UuidToCollection
+// fields are populated. To populate other fields call rc.Summarize().
 func MakeTestReadCollections(specs []TestCollectionSpec) (rc ReadCollections) {
 	rc = ReadCollections{
 		ReadAllCollections: true,
@@ -45,10 +46,10 @@ func MakeTestReadCollections(specs []TestCollectionSpec) (rc ReadCollections) {
 	return
 }
 
-// Returns a slice giving the collection index of each collection that
-// was passed in to MakeTestReadCollections. rc.Summarize() must be
-// called before this method, since Summarize() assigns an index to
-// each collection.
+// CollectionIndicesForTesting returns a slice giving the collection
+// index of each collection that was passed in to MakeTestReadCollections.
+// rc.Summarize() must be called before this method, since Summarize()
+// assigns an index to each collection.
 func (rc ReadCollections) CollectionIndicesForTesting() (indices []int) {
 	// TODO(misha): Assert that rc.Summarize() has been called.
 	numCollections := len(rc.CollectionIndexToUuid)

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list