[ARVADOS] updated: e35c34214b2893f329043f2cca7cc0233bac553f
git at public.curoverse.com
git at public.curoverse.com
Tue Sep 8 13:31:08 EDT 2015
Summary of changes:
services/keepstore/volume.go | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
via e35c34214b2893f329043f2cca7cc0233bac553f (commit)
from 35b91242eb6bcc002815519afa24effecd8fa6b6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit e35c34214b2893f329043f2cca7cc0233bac553f
Author: Tom Clegg <tom at curoverse.com>
Date: Tue Sep 8 13:31:04 2015 -0400
7121: Add comment about why buffers must be returned.
diff --git a/services/keepstore/volume.go b/services/keepstore/volume.go
index d17af44..bda7d87 100644
--- a/services/keepstore/volume.go
+++ b/services/keepstore/volume.go
@@ -13,7 +13,9 @@ import (
type Volume interface {
// Get a block. IFF the returned error is nil, the caller must
// put the returned slice back into the buffer pool when it's
- // finished with it.
+ // finished with it. (Otherwise, the buffer pool will be
+ // depleted and eventually -- when all available buffers are
+ // used and not returned -- operations will reach deadlock.)
Get(loc string) ([]byte, error)
// Confirm Get() would return a buffer with exactly the same
// content as buf. If so, return nil. If not, return
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list