[ARVADOS] updated: 9aef039747f280914873b17f8c5b64a44c42fd0a

[git at public.curoverse.com]

Summary of changes:
 sdk/go/arvadosclient/arvadosclient_test.go | 51 +++++++++++++++++-------------
 1 file changed, 29 insertions(+), 22 deletions(-)

       via  9aef039747f280914873b17f8c5b64a44c42fd0a (commit)
       via  9b91a7c2e783595b168a5aa101b4313f9dcce65e (commit)
       via  898c73ef5179e3c0cdc088ca369500b40df23b89 (commit)
      from  fe7b78b41bb12070559ebb693c21df18f65f0c99 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 9aef039747f280914873b17f8c5b64a44c42fd0a
Merge: fe7b78b 9b91a7c
Author: Tom Clegg <tom at curoverse.com>
Date:   Tue Nov 10 11:35:03 2015 -0500

    Merge branch '5538-test-post-retry' refs #5538


commit 9b91a7c2e783595b168a5aa101b4313f9dcce65e
Author: Tom Clegg <tom at curoverse.com>
Date:   Tue Nov 10 11:33:32 2015 -0500

    5538: Update comments to match new tests.

diff --git a/sdk/go/arvadosclient/arvadosclient_test.go b/sdk/go/arvadosclient/arvadosclient_test.go
index bf8debe..f2fd0b1 100644
--- a/sdk/go/arvadosclient/arvadosclient_test.go
+++ b/sdk/go/arvadosclient/arvadosclient_test.go
@@ -322,11 +322,16 @@ func (s *MockArvadosServerSuite) TestWithRetries(c *C) {
 		{
 			"get", 0, 401, []int{500, 401, 200}, []string{``, ``, `{"ok":"ok"}`},
 		},
-		// Use nil responseBody to simulate error during request processing
-		// Even though retryable, the simulated error applies during reties also, and hence "get" also eventually fails in this test.
+
+		// Response code -1 simulates an HTTP/network error
+		// (i.e., Do() returns an error; there is no HTTP
+		// response status code).
+
+		// Succeed on second retry
 		{
 			"get", 0, 200, []int{-1, -1, 200}, []string{``, ``, `{"ok":"ok"}`},
 		},
+		// "POST" is not safe to retry: fail after one error
 		{
 			"create", 0, -1, []int{-1, 200}, []string{``, `{"ok":"ok"}`},
 		},

-----------------------------------------------------------------------


hooks/post-receive
--