[ARVADOS] updated: e59bc286dd018450cce0b662eeff8effe393d8ae
git at public.curoverse.com
git at public.curoverse.com
Fri Mar 27 19:45:33 EDT 2015
Summary of changes:
apps/workbench/app/controllers/application_controller.rb | 9 ---------
.../app/views/application/_getting_started_popup.html.erb | 8 +++++++-
2 files changed, 7 insertions(+), 10 deletions(-)
via e59bc286dd018450cce0b662eeff8effe393d8ae (commit)
from 7ec30c76580397ca6b06bf1bbdb1ca9dc9f7af2f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit e59bc286dd018450cce0b662eeff8effe393d8ae
Author: Radhika Chippada <radhika at curoverse.com>
Date: Fri Mar 27 19:44:25 2015 -0400
5493: remove the helper method update_getting_started_shown_user_pref, and instead perform prefs update in the view itself.
diff --git a/apps/workbench/app/controllers/application_controller.rb b/apps/workbench/app/controllers/application_controller.rb
index db5e83b..1b59c57 100644
--- a/apps/workbench/app/controllers/application_controller.rb
+++ b/apps/workbench/app/controllers/application_controller.rb
@@ -700,15 +700,6 @@ class ApplicationController < ActionController::Base
missing_required
end
- helper_method :update_getting_started_shown_user_pref
- def update_getting_started_shown_user_pref
- prefs = current_user.prefs
- if !prefs[:getting_started_shown]
- prefs[:getting_started_shown] = Time.now
- current_user.update_attributes prefs: prefs.to_json
- end
- end
-
def select_theme
return Rails.configuration.arvados_theme
end
diff --git a/apps/workbench/app/views/application/_getting_started_popup.html.erb b/apps/workbench/app/views/application/_getting_started_popup.html.erb
index 28c3352..a12ae21 100644
--- a/apps/workbench/app/views/application/_getting_started_popup.html.erb
+++ b/apps/workbench/app/views/application/_getting_started_popup.html.erb
@@ -1,5 +1,11 @@
<%
- update_getting_started_shown_user_pref() if current_user
+ if current_user
+ prefs = current_user.prefs
+ if !prefs[:getting_started_shown]
+ prefs[:getting_started_shown] = Time.now
+ current_user.update_attributes prefs: prefs.to_json
+ end
+ end
%>
<div class="modal">
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list