[ARVADOS] updated: fc79e9d9109f84dd1c9851fd231d7d333914b54e
git at public.curoverse.com
git at public.curoverse.com
Tue Mar 10 15:43:09 EDT 2015
Summary of changes:
apps/workbench/test/integration/collection_upload_test.rb | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
discards b4fcabf6325304c7ca80c215fc7afabc3c94e9a6 (commit)
via fc79e9d9109f84dd1c9851fd231d7d333914b54e (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (b4fcabf6325304c7ca80c215fc7afabc3c94e9a6)
\
N -- N -- N (fc79e9d9109f84dd1c9851fd231d7d333914b54e)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit fc79e9d9109f84dd1c9851fd231d7d333914b54e
Author: Tom Clegg <tom at curoverse.com>
Date: Tue Mar 10 15:44:45 2015 -0400
5182: Tweak error messages.
diff --git a/apps/workbench/app/assets/javascripts/upload_to_collection.js b/apps/workbench/app/assets/javascripts/upload_to_collection.js
index 58ac3fe..55f562d 100644
--- a/apps/workbench/app/assets/javascripts/upload_to_collection.js
+++ b/apps/workbench/app/assets/javascripts/upload_to_collection.js
@@ -65,7 +65,7 @@ function UploadToCollection($scope, $filter, $q, $timeout,
////////////////////////////////
var keepProxy;
- var defaultErrorMessage = 'A network error occurred, or there is a CORS configuration problem. Please check your browser debug console for a more specific error message (browser security features prevent us from showing the details here).';
+ var defaultErrorMessage = 'A network error occurred: either the server was unreachable, or there is a server configuration problem. Please check your browser debug console for a more specific error message (browser security features prevent us from showing the details here).';
function SliceReader(_slice) {
var that = this;
@@ -127,7 +127,7 @@ function UploadToCollection($scope, $filter, $q, $timeout,
// give up now.
_deferred.reject({
textStatus: 'error',
- err: 'server setup problem (proxy ' + proxyUriBase() + ' cannot be used from origin ' + window.location.origin + ')'
+ err: 'There is a server configuration problem. Proxy ' + proxyUriBase() + ' cannot be used from origin ' + window.location.origin + ' due to the browser\'s mixed-content (https/http) policy.'
});
} else {
goSend();
diff --git a/apps/workbench/test/integration/collection_upload_test.rb b/apps/workbench/test/integration/collection_upload_test.rb
index 3f201b7..38b6026 100644
--- a/apps/workbench/test/integration/collection_upload_test.rb
+++ b/apps/workbench/test/integration/collection_upload_test.rb
@@ -86,7 +86,7 @@ class CollectionUploadTest < ActionDispatch::IntegrationTest
end
end
- test "Report CORS problem or network error" do
+ test "Report network error" do
need_selenium "to make file uploads work"
begin
use_token :admin
@@ -100,7 +100,6 @@ class CollectionUploadTest < ActionDispatch::IntegrationTest
assert_selector 'button:not([disabled])', text: 'Start'
click_button 'Start'
using_wait_time 5 do
- assert_text :visible, 'CORS'
assert_text :visible, 'network error'
end
end
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list