[ARVADOS] updated: 0db099d96a60ffafdaf0cdf14e92a4dc579e723e
git at public.curoverse.com
git at public.curoverse.com
Fri Jul 3 16:57:49 EDT 2015
Summary of changes:
services/api/app/mailers/user_notifier.rb | 2 +-
services/api/app/views/user_notifier/account_is_setup.text.erb | 7 ++++---
services/api/test/functional/arvados/v1/users_controller_test.rb | 8 +++-----
services/api/test/unit/user_notifier_test.rb | 8 +++-----
4 files changed, 11 insertions(+), 14 deletions(-)
via 0db099d96a60ffafdaf0cdf14e92a4dc579e723e (commit)
from cf8786f78aa3d8af225f1eaf2bd7c0a17cfa33fc (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 0db099d96a60ffafdaf0cdf14e92a4dc579e723e
Author: radhika <radhika at curoverse.com>
Date: Fri Jul 3 16:56:53 2015 -0400
6013: update user notification email upon setup.
diff --git a/services/api/app/mailers/user_notifier.rb b/services/api/app/mailers/user_notifier.rb
index 055fe3a..7c96d71 100644
--- a/services/api/app/mailers/user_notifier.rb
+++ b/services/api/app/mailers/user_notifier.rb
@@ -5,7 +5,7 @@ class UserNotifier < ActionMailer::Base
def account_is_setup(user)
@user = user
- mail(to: user.email, subject: 'Welcome to Curoverse')
+ mail(to: user.email, subject: 'Welcome to Curoverse - shell account enabled')
end
end
diff --git a/services/api/app/views/user_notifier/account_is_setup.text.erb b/services/api/app/views/user_notifier/account_is_setup.text.erb
index 5d8c9e7..480b6dd 100644
--- a/services/api/app/views/user_notifier/account_is_setup.text.erb
+++ b/services/api/app/views/user_notifier/account_is_setup.text.erb
@@ -4,10 +4,11 @@
Hi there,
<% end -%>
-Your Arvados account has been set up. You can log in with your Google account
-associated with the e-mail address <%= @user.email %><% if Rails.configuration.workbench_address %> at:
+Your Arvados shell account has been set up. Please visit the manage account page <% if Rails.configuration.workbench_address %>at
- <%= Rails.configuration.workbench_address %><% else %>.<% end %>
+ <%= Rails.configuration.workbench_address %>/manage_account <% else %><% end %>
+
+for connection instructions.
Thanks,
The Arvados team.
diff --git a/services/api/test/functional/arvados/v1/users_controller_test.rb b/services/api/test/functional/arvados/v1/users_controller_test.rb
index e87068c..c4a9964 100644
--- a/services/api/test/functional/arvados/v1/users_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/users_controller_test.rb
@@ -653,11 +653,9 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase
assert_equal Rails.configuration.user_notifier_email_from, setup_email.from[0]
assert_equal 'foo at example.com', setup_email.to[0]
- assert_equal 'Welcome to Curoverse', setup_email.subject
- assert (setup_email.body.to_s.include? 'Your Arvados account has been set up'),
- 'Expected Your Arvados account has been set up in email body'
- assert (setup_email.body.to_s.include? 'foo at example.com'),
- 'Expected user email in email body'
+ assert_equal 'Welcome to Curoverse - shell account enabled', setup_email.subject
+ assert (setup_email.body.to_s.include? 'Your Arvados shell account has been set up'),
+ 'Expected Your Arvados shell account has been set up in email body'
assert (setup_email.body.to_s.include? Rails.configuration.workbench_address),
'Expected workbench url in email body'
end
diff --git a/services/api/test/unit/user_notifier_test.rb b/services/api/test/unit/user_notifier_test.rb
index b280ae7..8629f29 100644
--- a/services/api/test/unit/user_notifier_test.rb
+++ b/services/api/test/unit/user_notifier_test.rb
@@ -12,11 +12,9 @@ class UserNotifierTest < ActionMailer::TestCase
# Test the body of the sent email contains what we expect it to
assert_equal Rails.configuration.user_notifier_email_from, email.from.first
assert_equal user.email, email.to.first
- assert_equal 'Welcome to Curoverse', email.subject
- assert (email.body.to_s.include? 'Your Arvados account has been set up'),
- 'Expected Your Arvados account has been set up in email body'
- assert (email.body.to_s.include? user.email),
- 'Expected user email in email body'
+ assert_equal 'Welcome to Curoverse - shell account enabled', email.subject
+ assert (email.body.to_s.include? 'Your Arvados shell account has been set up'),
+ 'Expected Your Arvados shell account has been set up in email body'
assert (email.body.to_s.include? Rails.configuration.workbench_address),
'Expected workbench url in email body'
end
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list