[ARVADOS] updated: 9c1021275fb005bac99b2d4abd96290b7d1aa8c8
git at public.curoverse.com
git at public.curoverse.com
Tue Jan 6 12:51:11 EST 2015
Summary of changes:
.../test/integration/pipeline_instances_test.rb | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
via 9c1021275fb005bac99b2d4abd96290b7d1aa8c8 (commit)
from 7b5c84ead3ac279088a02ae07f3354d5bba9c9aa (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 9c1021275fb005bac99b2d4abd96290b7d1aa8c8
Author: Tom Clegg <tom at curoverse.com>
Date: Tue Jan 6 12:26:49 2015 -0500
3021: Wait for dialog to close before asserting page transition.
diff --git a/apps/workbench/test/integration/pipeline_instances_test.rb b/apps/workbench/test/integration/pipeline_instances_test.rb
index e16cf72..b0dddc7 100644
--- a/apps/workbench/test/integration/pipeline_instances_test.rb
+++ b/apps/workbench/test/integration/pipeline_instances_test.rb
@@ -313,15 +313,21 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest
find('a,button', text: 'Re-run with latest').click
end
- # Verify that the newly created instance is created in the right project.
- # In case of project_viewer user, since the use cannot write to the project,
- # the pipeline should have been created in the user's Home project.
+ # Wait for the dialog to close. (Otherwise, the next assertion
+ # could fail while we're still looking at the source instance
+ # page, even if the correct behavior is about to happen.)
+ assert_no_selector 'body.modal-open'
+
+ # Verify that the newly created instance is created in the right
+ # project. In case of project_viewer user, since the user cannot
+ # write to the project, the pipeline should have been created in
+ # the user's Home project.
assert_not_equal instance_path, current_path, 'Rerun instance path expected to be different'
- assert page.has_text? 'Home'
+ assert_text 'Home'
if in_aproject && (user != 'project_viewer')
- assert page.has_text? 'A Project'
+ assert_text 'A Project'
else
- assert page.has_no_text? 'A Project'
+ assert_no_text? 'A Project'
end
end
end
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list