[ARVADOS] updated: e365089a7bcc016ce90997d3b3c93eb9f89b0eba

git at public.curoverse.com git at public.curoverse.com
Wed Dec 2 12:36:38 EST 2015


Summary of changes:
 services/datamanager/keep/keep.go         | 4 ++--
 services/datamanager/summary/pull_list.go | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

       via  e365089a7bcc016ce90997d3b3c93eb9f89b0eba (commit)
      from  bbf13d5bc532c5222a933317461f187a0e118c9a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit e365089a7bcc016ce90997d3b3c93eb9f89b0eba
Author: radhika <radhika at curoverse.com>
Date:   Wed Dec 2 12:36:12 2015 -0500

    7748: correct the local variable declaration

diff --git a/services/datamanager/keep/keep.go b/services/datamanager/keep/keep.go
index dace9a8..206a9c4 100644
--- a/services/datamanager/keep/keep.go
+++ b/services/datamanager/keep/keep.go
@@ -473,9 +473,9 @@ func SendTrashLists(arvLogger *logger.Logger, kc *keepclient.KeepClient, spl map
 	client := kc.Client
 
 	for url, v := range spl {
-		// We need a local variable because Update doesn't call our mutator func until later,
-		// when our list variable might have been reused by the next loop iteration.
 		if arvLogger != nil {
+			// We need a local variable because Update doesn't call our mutator func until later,
+			// when our list variable might have been reused by the next loop iteration.
 			url := url
 			trashLen := len(v)
 			arvLogger.Update(func(p map[string]interface{}, e map[string]interface{}) {
diff --git a/services/datamanager/summary/pull_list.go b/services/datamanager/summary/pull_list.go
index 6788576..aac9aec 100644
--- a/services/datamanager/summary/pull_list.go
+++ b/services/datamanager/summary/pull_list.go
@@ -183,9 +183,9 @@ func WritePullLists(arvLogger *logger.Logger,
 		if arvLogger != nil {
 			// We need a local variable because Update doesn't call our mutator func until later,
 			// when our list variable might have been reused by the next loop iteration.
+			host := host
+			listLen := len(list)
 			arvLogger.Update(func(p map[string]interface{}, e map[string]interface{}) {
-				host := host
-				listLen := len(list)
 				pullListInfo := logger.GetOrCreateMap(p, "pull_list_len")
 				pullListInfo[host] = listLen
 			})

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list