[ARVADOS] updated: 44d4d43331979c87cee5df9ff952fd80a6e9c5f8
git at public.curoverse.com
git at public.curoverse.com
Wed Aug 5 10:31:22 EDT 2015
Summary of changes:
apps/workbench/test/integration/user_settings_menu_test.rb | 10 +++++-----
services/api/app/views/user_notifier/account_is_setup.text.erb | 4 ++--
.../api/test/functional/arvados/v1/users_controller_test.rb | 2 ++
3 files changed, 9 insertions(+), 7 deletions(-)
via 44d4d43331979c87cee5df9ff952fd80a6e9c5f8 (commit)
from 89fccf123374c67e738381ea840e3535b2d1074f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 44d4d43331979c87cee5df9ff952fd80a6e9c5f8
Author: Manoj <jonam33 at gmail.com>
Date: Wed Aug 5 10:30:25 2015 -0400
6588: Removed last reference to manage account page and reworded tests
to not use manage account.
diff --git a/apps/workbench/test/integration/user_settings_menu_test.rb b/apps/workbench/test/integration/user_settings_menu_test.rb
index c2a2f8a..57f62d5 100644
--- a/apps/workbench/test/integration/user_settings_menu_test.rb
+++ b/apps/workbench/test/integration/user_settings_menu_test.rb
@@ -5,8 +5,8 @@ class UserSettingsMenuTest < ActionDispatch::IntegrationTest
need_javascript
end
- # test manage_account page
- def verify_manage_account user
+ # test ssh_keys page
+ def verify_settings_menu user
if user['is_active']
within('.navbar-fixed-top') do
page.find("#notifications-menu").click
@@ -66,9 +66,9 @@ class UserSettingsMenuTest < ActionDispatch::IntegrationTest
['active', api_fixture('users')['active']],
['admin', api_fixture('users')['admin']],
].each do |token, user|
- test "test manage account for user #{token}" do
+ test "test settings menu for user #{token}" do
visit page_with_token(token)
- verify_manage_account user
+ verify_settings_menu user
end
end
@@ -84,7 +84,7 @@ class UserSettingsMenuTest < ActionDispatch::IntegrationTest
['job_reader', :ssh, :pipeline],
['active'],
].each do |user, *expect|
- test "manage account for #{user} with notifications #{expect.inspect}" do
+ test "settings menu for #{user} with notifications #{expect.inspect}" do
Rails.configuration.anonymous_user_token = false
visit page_with_token(user)
click_link 'notifications-menu'
diff --git a/services/api/app/views/user_notifier/account_is_setup.text.erb b/services/api/app/views/user_notifier/account_is_setup.text.erb
index 480b6dd..8f9e058 100644
--- a/services/api/app/views/user_notifier/account_is_setup.text.erb
+++ b/services/api/app/views/user_notifier/account_is_setup.text.erb
@@ -4,9 +4,9 @@
Hi there,
<% end -%>
-Your Arvados shell account has been set up. Please visit the manage account page <% if Rails.configuration.workbench_address %>at
+Your Arvados shell account has been set up. Please visit the virtual machines page <% if Rails.configuration.workbench_address %>at
- <%= Rails.configuration.workbench_address %>/manage_account <% else %><% end %>
+ <%= Rails.configuration.workbench_address %>users/<%= @user.uuid%>/virtual_machines <% else %><% end %>
for connection instructions.
diff --git a/services/api/test/functional/arvados/v1/users_controller_test.rb b/services/api/test/functional/arvados/v1/users_controller_test.rb
index c4a9964..62ed878 100644
--- a/services/api/test/functional/arvados/v1/users_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/users_controller_test.rb
@@ -656,6 +656,8 @@ class Arvados::V1::UsersControllerTest < ActionController::TestCase
assert_equal 'Welcome to Curoverse - shell account enabled', setup_email.subject
assert (setup_email.body.to_s.include? 'Your Arvados shell account has been set up'),
'Expected Your Arvados shell account has been set up in email body'
+ assert (setup_email.body.to_s.include? '/virtual_machines'),
+ 'Expected /virtual_machines link to appear in email body'
assert (setup_email.body.to_s.include? Rails.configuration.workbench_address),
'Expected workbench url in email body'
end
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list