[ARVADOS] updated: 9c76a339554da1c515c7e68d68a74dc9e19ec08d

git at public.curoverse.com git at public.curoverse.com
Tue Apr 28 09:54:33 EDT 2015


Summary of changes:
 .../app/assets/javascripts/infinite_scroll.js      |  34 +++++++
 apps/workbench/app/controllers/jobs_controller.rb  |   2 -
 .../controllers/pipeline_instances_controller.rb   |   2 +-
 apps/workbench/app/helpers/application_helper.rb   |   2 +-
 apps/workbench/app/helpers/jobs_helper.rb          |  22 -----
 apps/workbench/app/models/pipeline_instance.rb     |  52 ++++++++++
 .../app/views/application/_choose.html.erb         |   4 +
 .../app/views/application/_content.html.erb        |  12 +--
 .../app/views/application/_show_sharing.html.erb   |   1 +
 .../views/pipeline_instances/_show_log.html.erb    |  56 ++++++++---
 apps/workbench/test/helpers/share_object_helper.rb |   1 +
 .../test/integration/anonymous_access_test.rb      |  29 +++---
 .../test/integration/pipeline_instances_test.rb    |  41 ++++++++
 apps/workbench/test/unit/pipeline_instance_test.rb |  66 ++++++++++++-
 services/api/Rakefile                              |  21 ++++
 .../app/controllers/arvados/v1/jobs_controller.rb  |  27 +++++-
 services/api/config/application.default.yml        |   5 +
 services/api/lib/tasks/delete_old_job_logs.rake    |  17 ++++
 services/api/lib/tasks/test_tasks.rake             |   6 ++
 services/api/test/fixtures/jobs.yml                |  53 +++++++++-
 services/api/test/fixtures/links.yml               |  30 ++++++
 services/api/test/fixtures/logs.yml                |  38 ++++++++
 services/api/test/fixtures/pipeline_instances.yml  |  42 +++++++-
 services/api/test/fixtures/repositories.yml        |   7 ++
 .../arvados/v1/job_reuse_controller_test.rb        | 108 +++++++++++++++------
 .../api/test/tasks/delete_old_job_logs_test.rb     |  50 ++++++++++
 services/api/test/test.git.tar                     | Bin 194560 -> 256000 bytes
 services/api/test/unit/collection_test.rb          |   7 ++
 services/api/test/unit/commit_test.rb              |  60 ++++++++++++
 services/api/test/unit/job_test.rb                 |  10 ++
 30 files changed, 708 insertions(+), 97 deletions(-)
 delete mode 100644 apps/workbench/app/helpers/jobs_helper.rb
 create mode 100644 services/api/lib/tasks/delete_old_job_logs.rake
 create mode 100644 services/api/lib/tasks/test_tasks.rake
 create mode 100644 services/api/test/tasks/delete_old_job_logs_test.rb

       via  9c76a339554da1c515c7e68d68a74dc9e19ec08d (commit)
       via  a6136a820fae4cc3b657fb3e16a26b9a2ee08349 (commit)
       via  8464bb48ba769c8bf0984c8b1493ca43fd902891 (commit)
       via  5b1602a521d3f6689f5988cdc2b25b74ff9fc1e1 (commit)
       via  03d89302f14a4a1c448b32d62679bab14e23fa23 (commit)
       via  68dfd41d1d5038f7e0a139779ef6ce1c4a7a8351 (commit)
       via  5b0d540ad315ad390831ad58f52b02e86686524f (commit)
       via  4b17e78749b44772e898619e11aef663810ac6ed (commit)
       via  d054beda9bc86bc6cd33a127f4d9e40d04f1620d (commit)
       via  9bfd0d772abcd643e92fed127112e0ed91c00e65 (commit)
       via  11a007fd7bbc3b35b6efd62c84d9ca5a8f45aecb (commit)
       via  97403e08475b328115373a2c6a23e82116199aad (commit)
       via  45b556d1a204f694b69ca26d115cd6786ca585f3 (commit)
       via  123ef960b82540b98c8b68c47ff89bf85da3899c (commit)
       via  81fb9f6e13d6e48e23165319ff8f2f9cab4deb3f (commit)
       via  b1db376a4532ba3484929b3214e59056877d1695 (commit)
       via  816683553b8353f18c92f32a6ee9ea1868630067 (commit)
       via  f6f6ed672a240c9b91e78591b4f67a5ed4250758 (commit)
      from  5b953441aba0b15851ef0821d08dc2933216eac2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 9c76a339554da1c515c7e68d68a74dc9e19ec08d
Author: Radhika Chippada <radhika at curoverse.com>
Date:   Tue Apr 28 09:40:15 2015 -0400

    5622: add comments to infinite_scroll.js explaining how to add infinite scrolling to a page.

diff --git a/apps/workbench/app/assets/javascripts/infinite_scroll.js b/apps/workbench/app/assets/javascripts/infinite_scroll.js
index 81a3a46..6e467f5 100644
--- a/apps/workbench/app/assets/javascripts/infinite_scroll.js
+++ b/apps/workbench/app/assets/javascripts/infinite_scroll.js
@@ -1,3 +1,37 @@
+// infinite_scroll.js displays a tab's content using automatic scrolling
+// when the user scrolls to the bottom of the page and there is more data.
+//
+// Usage:
+//
+// 1. Adding infinite scrolling to a tab pane using "show" method
+//
+//  The steps below describe adding scrolling to the project#show action.
+//
+//  a. In the "app/views/projects/" folder add a file for your tab
+//      (ex: _show_jobs_and_pipelines.html.erb)
+//    In this file, add a div or tbody with data-infinite-scroller.
+//      Note: This page uses _show_tab_contents.html.erb so that
+//            several tabs can reuse this implementation.
+//    Also add the filters to be used for loading the tab content.
+//
+//  b. Add a file named "_show_contents_rows.html.erb" that loads
+//    the data (by invoking get_objects_and_names from the controller).
+//
+//  c. In the "app/controllers/projects_controller.rb,
+//    Update the show method to add a block for "params[:partial]"
+//      that loads the show_contents_rows partial.
+//    Optionally, add a "tab_counts" method that loads the total number
+//      of objects count to be displayed for this tab.
+//
+// 2. Adding infinite scrolling to the "Recent" tab in "index" page
+//  The steps below describe adding scrolling to the pipeline_instances index page.
+//
+//  a. In the "app/views/pipeline_instances/_show_recent.html.erb/" file
+//      add a div or tbody with data-infinite-scroller.
+//
+//  b. Add the partial "_show_recent_rows.html.erb" that displays the
+//      page contents on scroll using the @objects
+
 function maybe_load_more_content(event) {
     var scroller = this;
     var $container = $(event.data.container);

commit a6136a820fae4cc3b657fb3e16a26b9a2ee08349
Merge: 5b95344 8464bb4
Author: Radhika Chippada <radhika at curoverse.com>
Date:   Tue Apr 28 08:18:59 2015 -0400

    Merge branch 'master' into 5622-pdh-collections-page-paging


-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list