[ARVADOS] updated: c5cd44ad4ff0b5d65cab30b8eb702ab3e238a499

git at public.curoverse.com git at public.curoverse.com
Mon Apr 20 12:29:36 EDT 2015


Summary of changes:
 apps/workbench/app/assets/javascripts/application.js | 3 +++
 apps/workbench/app/helpers/application_helper.rb     | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

       via  c5cd44ad4ff0b5d65cab30b8eb702ab3e238a499 (commit)
      from  4ccec6c3e6e96edc4917f15769a30e187484ee52 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit c5cd44ad4ff0b5d65cab30b8eb702ab3e238a499
Author: Radhika Chippada <radhika at curoverse.com>
Date:   Mon Apr 20 11:42:04 2015 -0400

    5620: added comment to input trigger event

diff --git a/apps/workbench/app/assets/javascripts/application.js b/apps/workbench/app/assets/javascripts/application.js
index 3183fb7..65e856d 100644
--- a/apps/workbench/app/assets/javascripts/application.js
+++ b/apps/workbench/app/assets/javascripts/application.js
@@ -147,6 +147,9 @@ jQuery(function($){
             $('.modal').attr('tabindex', '-1')
         }).
         on('ready', function() {
+            // Need this to trigger input validation/synchronization callbacks because some browsers
+            // auto-fill form fields (e.g., when navigating "back" to a page where some text
+            // had been entered in a search box) without triggering a change or input event.
             $('input').trigger('input');
         });
 
diff --git a/apps/workbench/app/helpers/application_helper.rb b/apps/workbench/app/helpers/application_helper.rb
index 1755e79..d1655b9 100644
--- a/apps/workbench/app/helpers/application_helper.rb
+++ b/apps/workbench/app/helpers/application_helper.rb
@@ -364,7 +364,7 @@ module ApplicationHelper
            success: 'page-refresh'
          }.to_json,
         })
-      is_readable_input = object_readable attrvalue, Collection unless attrvalue.andand.empty?
+      is_readable_input = attrvalue.present? and object_readable attrvalue, Collection
       return content_tag('div', :class => 'input-group') do
         html = text_field_tag(dn, display_value,
                               :class =>

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list