[ARVADOS] updated: b39e2b4e3f791d0c0afe9682183bd31d8341cea3

git at public.curoverse.com git at public.curoverse.com
Thu Oct 30 17:05:41 EDT 2014


Summary of changes:
 sdk/cli/bin/crunch-job | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

       via  b39e2b4e3f791d0c0afe9682183bd31d8341cea3 (commit)
      from  c199c0cf4a2fe22ce3e1dd0e6219937588711c50 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit b39e2b4e3f791d0c0afe9682183bd31d8341cea3
Author: Tom Clegg <tom at curoverse.com>
Date:   Thu Oct 30 17:05:25 2014 -0400

    3824: Fix comment to state that tasks must not assume $TASK_KEEPMOUNT is /keep.

diff --git a/sdk/cli/bin/crunch-job b/sdk/cli/bin/crunch-job
index 9adbfac..617d22f 100755
--- a/sdk/cli/bin/crunch-job
+++ b/sdk/cli/bin/crunch-job
@@ -739,10 +739,11 @@ for (my $todo_ptr = 0; $todo_ptr <= $#jobstep_todo; $todo_ptr ++)
       $command .= "--volume=\Q$ENV{CRUNCH_SRC}:$ENV{CRUNCH_SRC}:ro\E ";
       $command .= "--volume=\Q$ENV{CRUNCH_INSTALL}:$ENV{CRUNCH_INSTALL}:ro\E ";
 
-      # For some reason we make arv-mount's mount point appear at
-      # /keep inside the container, instead of using the same path as
-      # the host and expecting the task to pay attention to
-      # $TASK_KEEPMOUNT like we do with everything else.
+      # Currently, we make arv-mount's mount point appear at /keep
+      # inside the container (instead of using the same path as the
+      # host like we do with CRUNCH_SRC and CRUNCH_INSTALL). However,
+      # crunch scripts and utilities must not rely on this. They must
+      # use $TASK_KEEPMOUNT.
       $command .= "--volume=\Q$ENV{TASK_KEEPMOUNT}:/keep:ro\E ";
       $ENV{TASK_KEEPMOUNT} = "/keep";
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list