[ARVADOS] updated: a3ba50fde463c980a739f8a8f8bdd04001348132

git at public.curoverse.com git at public.curoverse.com
Thu Oct 23 15:36:57 EDT 2014


Summary of changes:
 doc/api/methods/nodes.html.textile.liquid                        | 2 +-
 services/api/app/controllers/arvados/v1/nodes_controller.rb      | 5 -----
 services/api/test/functional/arvados/v1/nodes_controller_test.rb | 2 +-
 3 files changed, 2 insertions(+), 7 deletions(-)

       via  a3ba50fde463c980a739f8a8f8bdd04001348132 (commit)
      from  7678627008122e2f832acee56f5b3b9af6255a17 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit a3ba50fde463c980a739f8a8f8bdd04001348132
Author: Brett Smith <brett at curoverse.com>
Date:   Thu Oct 23 15:36:52 2014 -0400

    4139: Node create API requires a node parameter.
    
    This makes it more consistent with other API create methods.

diff --git a/doc/api/methods/nodes.html.textile.liquid b/doc/api/methods/nodes.html.textile.liquid
index b2c7924..7aa5896 100644
--- a/doc/api/methods/nodes.html.textile.liquid
+++ b/doc/api/methods/nodes.html.textile.liquid
@@ -21,7 +21,7 @@ Arguments:
 
 table(table table-bordered table-condensed).
 |_. Argument |_. Type |_. Description |_. Location |_. Example |
-|node|object||query||
+{background:#ccffcc}.|node|object||query||
 
 h2. delete
 
diff --git a/services/api/app/controllers/arvados/v1/nodes_controller.rb b/services/api/app/controllers/arvados/v1/nodes_controller.rb
index 69e032b..f2a04b3 100644
--- a/services/api/app/controllers/arvados/v1/nodes_controller.rb
+++ b/services/api/app/controllers/arvados/v1/nodes_controller.rb
@@ -3,11 +3,6 @@ class Arvados::V1::NodesController < ApplicationController
   skip_before_filter :find_object_by_uuid, :only => :ping
   skip_before_filter :render_404_if_no_object, :only => :ping
 
-  def create
-    @attrs = {}
-    super
-  end
-
   def update
     if resource_attrs[:job_uuid]
       @object.job_readable = readable_job_uuids(resource_attrs[:job_uuid]).any?
diff --git a/services/api/test/functional/arvados/v1/nodes_controller_test.rb b/services/api/test/functional/arvados/v1/nodes_controller_test.rb
index dd942b6..d744505 100644
--- a/services/api/test/functional/arvados/v1/nodes_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/nodes_controller_test.rb
@@ -68,7 +68,7 @@ class Arvados::V1::NodesControllerTest < ActionController::TestCase
 
   test "create node" do
     authorize_with :admin
-    post :create
+    post :create, {node: {}}
     assert_response :success
     assert_not_nil json_response['uuid']
     assert_not_nil json_response['info'].is_a? Hash

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list