[ARVADOS] updated: d7d1d0f327ddc42d2d06b836863f51e09793894b

[git at public.curoverse.com]

Summary of changes:
 services/api/app/models/user.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

       via  d7d1d0f327ddc42d2d06b836863f51e09793894b (commit)
      from  e79e5c258fe6ec542c3f2bb3c4230a5de2812b25 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit d7d1d0f327ddc42d2d06b836863f51e09793894b
Author: Tom Clegg <tom at curoverse.com>
Date:   Fri Oct 3 19:59:00 2014 -0400

    3687: Add comment about redundant lookup.

diff --git a/services/api/app/models/user.rb b/services/api/app/models/user.rb
index f283ea3..6e7facd 100644
--- a/services/api/app/models/user.rb
+++ b/services/api/app/models/user.rb
@@ -83,7 +83,10 @@ class User < ArvadosModel
                          end
       if sufficient_perms
         # Check permission links with head_uuid pointing directly at
-        # the target object
+        # the target object. If target is a Group, this is redundant
+        # and will fail except [a] if permission caching is broken or
+        # [b] during a race condition, where a permission link has
+        # *just* been added.
         if Link.where(link_class: 'permission',
                       name: sufficient_perms,
                       tail_uuid: groups_i_can(action) + [self.uuid],

-----------------------------------------------------------------------


hooks/post-receive
--