[ARVADOS] created: a434d701ca01cf933ecc460bd7d49eef8ef04800

[git at public.curoverse.com]

        at  a434d701ca01cf933ecc460bd7d49eef8ef04800 (commit)


commit a434d701ca01cf933ecc460bd7d49eef8ef04800
Author: Tom Clegg <tom at curoverse.com>
Date:   Sat Nov 1 14:28:12 2014 -0400

    4084: Do not reload up-to-date panes when switching tabs.

diff --git a/apps/workbench/app/assets/javascripts/tab_panes.js b/apps/workbench/app/assets/javascripts/tab_panes.js
index 496693d..b491701 100644
--- a/apps/workbench/app/assets/javascripts/tab_panes.js
+++ b/apps/workbench/app/assets/javascripts/tab_panes.js
@@ -2,8 +2,11 @@
 
 // Fire when a tab is selected/clicked.
 $(document).on('shown.bs.tab', '[data-toggle="tab"]', function(event) {
-    // Now trigger reload of the newly shown tab pane.
-    $(event.target).trigger('arv:pane:reload');
+    var $anchor = $(event.target);
+    if (!$anchor.hasClass('pane-loaded')) {
+        // This tab's pane is stale or not loaded at all. Trigger a reload.
+        $anchor.trigger('arv:pane:reload');
+    }
 });
 
 // Ask a refreshable pane to reload via ajax.

commit e0b4da871f18ddcea76aa89b77c5c3f90b2b2ac5
Author: Tom Clegg <tom at curoverse.com>
Date:   Sat Nov 1 14:25:06 2014 -0400

    4084: Bootstrap manages the "active" class on tabs, not us.

diff --git a/apps/workbench/app/assets/javascripts/tab_panes.js b/apps/workbench/app/assets/javascripts/tab_panes.js
index 6356055..496693d 100644
--- a/apps/workbench/app/assets/javascripts/tab_panes.js
+++ b/apps/workbench/app/assets/javascripts/tab_panes.js
@@ -2,22 +2,6 @@
 
 // Fire when a tab is selected/clicked.
 $(document).on('shown.bs.tab', '[data-toggle="tab"]', function(event) {
-    // When we switch tabs, remove "active" from any refreshable panes within
-    // the previous tab content so they don't continue to refresh unnecessarily, and
-    // add "active" to any refreshable panes under the newly shown tab content.
-
-    var tgt = $($(event.relatedTarget).attr('href'));
-    $(".pane-anchor", tgt).each(function (i, e) {
-        var a = $($(e).attr('href'));
-        a.removeClass("active");
-    });
-
-    tgt = $($(event.target).attr('href'));
-    $(".pane-anchor", tgt).each(function (i, e) {
-        var a = $($(e).attr('href'));
-        a.addClass("active");
-    });
-
     // Now trigger reload of the newly shown tab pane.
     $(event.target).trigger('arv:pane:reload');
 });

-----------------------------------------------------------------------


hooks/post-receive
--