[ARVADOS] updated: e661ffb13884990e8c359fc4ed973db1d7f95db9

[git at public.curoverse.com]

Summary of changes:
 sdk/cli/bin/arv-run-pipeline-instance |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

       via  e661ffb13884990e8c359fc4ed973db1d7f95db9 (commit)
      from  fbbb1beaca00df2d1483087451b81ed3c40953a9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit e661ffb13884990e8c359fc4ed973db1d7f95db9
Author: Tom Clegg <tom at curoverse.com>
Date:   Fri Mar 28 12:31:14 2014 -0400

    Clarify c_already_finished comments.

diff --git a/sdk/cli/bin/arv-run-pipeline-instance b/sdk/cli/bin/arv-run-pipeline-instance
index 8a16492..7ddea30 100755
--- a/sdk/cli/bin/arv-run-pipeline-instance
+++ b/sdk/cli/bin/arv-run-pipeline-instance
@@ -426,6 +426,9 @@ class WhRunPipelineInstance
       moretodo = false
       @components.each do |cname, c|
         job = nil
+        # Is the job satisfying this component already known to be
+        # finished? (Already meaning "before we query API server about
+        # the job's current state")
         c_already_finished = (c[:job] &&
                               c[:job][:uuid] &&
                               !c[:job][:success].nil?)
@@ -471,10 +474,12 @@ class WhRunPipelineInstance
               end
             end
             unless c_already_finished
+              # This is my first time discovering that the job
+              # succeeded. (At the top of this loop, I was still
+              # waiting for it to finish.)
               if c[:output_is_persistent]
-                # This is my first time discovering that the job
-                # succeeded. I need to make sure a resources/wants
-                # link is in place to protect the output from garbage
+                # I need to make sure a resources/wants link is in
+                # place to protect the output from garbage
                 # collection. (Normally Crunch does this for me, but
                 # here I might be reusing the output of someone else's
                 # job and I need to make sure it's understood that the

-----------------------------------------------------------------------


hooks/post-receive
--