[ARVADOS] updated: fb460bdf4b45dd9d8b46951a1457a301bd565430

[git at public.curoverse.com]

Summary of changes:
 services/keep/src/keep/handler_test.go | 9 +++++++--
 services/keep/src/keep/handlers.go     | 1 +
 2 files changed, 8 insertions(+), 2 deletions(-)

       via  fb460bdf4b45dd9d8b46951a1457a301bd565430 (commit)
      from  b9d9b77e04adb656aa9ab37d2688aef7ce0b8b2a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit fb460bdf4b45dd9d8b46951a1457a301bd565430
Author: Tim Pierce <twp at curoverse.com>
Date:   Thu Jul 31 11:45:12 2014 -0400

    2769: code review comments
    
    * Updated TODO in handler_test.go.
    * Log DELETE requests in DeleteHandler.
    
    Refs #2769

diff --git a/services/keep/src/keep/handler_test.go b/services/keep/src/keep/handler_test.go
index cab203d..2998f60 100644
--- a/services/keep/src/keep/handler_test.go
+++ b/services/keep/src/keep/handler_test.go
@@ -431,8 +431,13 @@ func TestIndexHandler(t *testing.T) {
 //
 //   TODO(twp):
 //
-//   * Delete block on read-only volume
-//     (test for 200 OK, response counts, confirm block not deleted)
+//   * Delete block on read-only and read-write volume
+//     (test for 200 OK, response with copies_deleted=1,
+//     copies_failed=1, confirm block deleted only on r/w volume)
+//
+//   * Delete block on read-only volume only
+//     (test for 200 OK, response with copies_deleted=0, copies_failed=1,
+//     confirm block not deleted)
 //
 func TestDeleteHandler(t *testing.T) {
 	defer teardown()
diff --git a/services/keep/src/keep/handlers.go b/services/keep/src/keep/handlers.go
index 234e21a..b9b8cae 100644
--- a/services/keep/src/keep/handlers.go
+++ b/services/keep/src/keep/handlers.go
@@ -336,6 +336,7 @@ func GetVolumeStatus(volume string) *VolumeStatus {
 //
 func DeleteHandler(resp http.ResponseWriter, req *http.Request) {
 	hash := mux.Vars(req)["hash"]
+	log.Printf("%s %s", req.Method, hash)
 
 	// Confirm that this user is an admin and has a token with unlimited scope.
 	var tok = GetApiToken(req)

-----------------------------------------------------------------------


hooks/post-receive
--