[ARVADOS] updated: d5b8f4baf23f0b79e2f9b559b1da6f8898292f9f

git at public.curoverse.com git at public.curoverse.com
Mon Jul 21 13:06:20 EDT 2014


Summary of changes:
 .../app/assets/javascripts/pipeline_instances.js   |  6 +++
 apps/workbench/app/assets/javascripts/sizing.js    |  1 +
 apps/workbench/app/assets/javascripts/tab_panes.js | 38 +++++++++++++++++
 .../app/views/application/_content.html.erb        | 48 ++--------------------
 .../pipeline_instances/_show_components.html.erb   |  2 +-
 .../app/views/pipeline_instances/show.html.erb     |  6 ---
 6 files changed, 50 insertions(+), 51 deletions(-)
 create mode 100644 apps/workbench/app/assets/javascripts/tab_panes.js

       via  d5b8f4baf23f0b79e2f9b559b1da6f8898292f9f (commit)
       via  e3a4fe6e461ec3ffde76e973ada7abae52faf050 (commit)
       via  fe8e80e434724578b29d79038a75f677df2ad400 (commit)
       via  6a2406f04875497a7bfad72fc8bcd73b792fefae (commit)
       via  d188143b2acd99dc594231360eeaf3e178794ff8 (commit)
      from  2fccbc1d172fe4bd680651261adfdca8f1ba2a63 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit d5b8f4baf23f0b79e2f9b559b1da6f8898292f9f
Merge: 2fccbc1 e3a4fe6
Author: Tom Clegg <tom at curoverse.com>
Date:   Mon Jul 21 13:02:17 2014 -0400

    Merge branch '3170-refresh-tab-pane'
    closes #3170


commit e3a4fe6e461ec3ffde76e973ada7abae52faf050
Merge: fe8e80e 230ac95
Author: Tom Clegg <tom at curoverse.com>
Date:   Mon Jul 21 13:00:42 2014 -0400

    3170: Merge branch 'master' into 3170-refresh-tab-pane


commit fe8e80e434724578b29d79038a75f677df2ad400
Author: Tom Clegg <tom at curoverse.com>
Date:   Mon Jul 21 13:00:34 2014 -0400

    3170: Add comments.

diff --git a/apps/workbench/app/assets/javascripts/tab_panes.js b/apps/workbench/app/assets/javascripts/tab_panes.js
index 9586e4c..ec4a519 100644
--- a/apps/workbench/app/assets/javascripts/tab_panes.js
+++ b/apps/workbench/app/assets/javascripts/tab_panes.js
@@ -1,3 +1,8 @@
+// Load tab panes on demand. See app/views/application/_content.html.erb
+
+// Fire when a tab is selected/clicked. Check whether the content in
+// the corresponding pane is loaded (or is being loaded). If not,
+// start an AJAX request to load the content.
 $(document).on('shown.bs.tab', '[data-toggle="tab"]', function(e) {
     var content_url = $(e.target).attr('data-pane-content-url');
     var $pane = $($(e.target).attr('href'));
@@ -10,6 +15,10 @@ $(document).on('shown.bs.tab', '[data-toggle="tab"]', function(e) {
         });
 });
 
+// Fire when the content in a tab pane becomes stale/dirty. If the
+// pane is visible now, reload it right away. Otherwise, just replace
+// the current content with a spinner for now: there's no need to load
+// the new content unless/until the user clicks the corresponding tab.
 $(document).on('arv:pane:reload', '.tab-pane', function() {
     // Unload a single pane. Reload it if it's active.
     $(this).removeClass('loaded');
@@ -23,7 +32,7 @@ $(document).on('arv:pane:reload', '.tab-pane', function() {
     }
 });
 
+// Mark all panes as stale/dirty. Refresh the active pane.
 $(document).on('arv-log-event arv:pane:reload:all', function() {
-    // Reload all panes (except ones that haven't even loaded yet).
     $('.tab-pane.loaded').trigger('arv:pane:reload');
 });

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list