[ARVADOS] updated: 44365f7532b85d73322b1a702bf458b489ee0e27

git at public.curoverse.com git at public.curoverse.com
Tue Dec 9 03:40:27 EST 2014


Summary of changes:
 apps/workbench/app/assets/javascripts/angular_shim.js | 10 +++++-----
 apps/workbench/app/assets/javascripts/tab_panes.js    |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

       via  44365f7532b85d73322b1a702bf458b489ee0e27 (commit)
      from  28cb528637cb4326def40d07d349108acce3d383 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 44365f7532b85d73322b1a702bf458b489ee0e27
Author: Tom Clegg <tom at curoverse.com>
Date:   Tue Dec 9 03:37:48 2014 -0500

    3781: Fix trigger() usage: second argument is an array of handler args.

diff --git a/apps/workbench/app/assets/javascripts/angular_shim.js b/apps/workbench/app/assets/javascripts/angular_shim.js
index a480eaf..a5366e3 100644
--- a/apps/workbench/app/assets/javascripts/angular_shim.js
+++ b/apps/workbench/app/assets/javascripts/angular_shim.js
@@ -2,11 +2,11 @@
 // Currently this only works for tabs because they emit an
 // arv:pane:loaded event after updating the DOM.
 
-$(document).on('arv:pane:loaded', function(event, updatedElement) {
-    if (updatedElement) {
-        angular.element(updatedElement).injector().invoke(function($compile) {
-            var scope = angular.element(updatedElement).scope();
-            $compile(updatedElement)(scope);
+$(document).on('arv:pane:loaded', function(event, $updatedElement) {
+    if ($updatedElement) {
+        angular.element($updatedElement).injector().invoke(function($compile) {
+            var scope = angular.element($updatedElement).scope();
+            $compile($updatedElement)(scope);
         });
     }
 });
diff --git a/apps/workbench/app/assets/javascripts/tab_panes.js b/apps/workbench/app/assets/javascripts/tab_panes.js
index f603440..6565ea9 100644
--- a/apps/workbench/app/assets/javascripts/tab_panes.js
+++ b/apps/workbench/app/assets/javascripts/tab_panes.js
@@ -124,7 +124,7 @@ $(document).on('arv:pane:reload', '[data-pane-content-url]', function(e) {
             $pane.removeClass('pane-loading');
             $pane.addClass('pane-loaded');
             $pane.attr('data-loaded-at', (new Date()).getTime());
-            $pane.trigger('arv:pane:loaded', $pane);
+            $pane.trigger('arv:pane:loaded', [$pane]);
 
             if ($pane.hasClass('pane-stale')) {
                 $pane.trigger('arv:pane:reload');

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list