[ARVADOS] updated: c96deb58149e6b31efd13d45170dc7f70a6109ea

git at public.curoverse.com git at public.curoverse.com
Thu Aug 28 16:05:31 EDT 2014


Summary of changes:
 apps/workbench/app/helpers/application_helper.rb   | 18 ++++++----
 .../views/application/_selection_checkbox.html.erb |  2 +-
 .../views/application/report_issue_popup.js.erb    | 17 ++++------
 .../app/views/projects/_index_projects.html.erb    |  2 +-
 apps/workbench/test/integration/projects_test.rb   | 20 ++++++++---
 .../test/integration/report_issue_test.rb          |  2 +-
 crunch_scripts/crunchutil/robust_put.py            | 13 +++++---
 crunch_scripts/crunchutil/subst.py                 | 39 +++++++++++++---------
 crunch_scripts/run-command                         | 35 +++++++++++--------
 sdk/cli/bin/crunch-job                             | 13 ++++++--
 sdk/python/arvados/commands/put.py                 |  8 ++++-
 .../functional/arvados/v1/jobs_controller_test.rb  |  2 --
 services/crunchstat/crunchstat.go                  |  7 ++++
 13 files changed, 114 insertions(+), 64 deletions(-)

       via  c96deb58149e6b31efd13d45170dc7f70a6109ea (commit)
       via  0368e13ebc5a5cfef0c69124cae34301a6d890ff (commit)
       via  97473ddf7cd581a048af7b6585ce3ef75ff502c0 (commit)
       via  462fbba4ab742a72a3cf057dc06610a51af6b0f0 (commit)
       via  4fc443bfedf165307795e2b9e6c022008b5d7639 (commit)
       via  5336eb79c94257d900f67491b901d38d33a54ce2 (commit)
       via  c2add3a97bc2d473b9f892962901881bf4b63a6c (commit)
       via  050a8d39b9ca831073520316dbc197270b11720d (commit)
       via  8350db2288e8f915bb70328e89c2717d69ba62ad (commit)
       via  c59670ea1fd789bf084b83fb33be3b84312dc07b (commit)
       via  638c2c2258e7004f9a86277588d50f1243a297c8 (commit)
       via  78317dade4e29b06f1f83b16603cc8ef5c42c434 (commit)
       via  55ed403e8bd408c70ce97cefc10156141ccd46a6 (commit)
       via  d1f510e7fa9f1b2656c54c1e9b3ea4e4466c9d1e (commit)
       via  78f13ceb188def121a548c0247b58cebce682b44 (commit)
       via  22954b4f9df4682aab32c59ee582def7865377af (commit)
       via  7aea6d3d35bc622818dbb62929a7f7fc75a4aeaf (commit)
       via  d199bf8a0732563a65f19538c6fa66b00f820f66 (commit)
       via  e32be386f2378807a79da5810414982769aa046c (commit)
       via  2b43d13d95893044467a96e3a0032aef36d65f03 (commit)
       via  0fe8a55af3116f6097fcbb8c18775ac35c32274b (commit)
       via  0b3427a023ddfb5443e5c63ad65b2ef80d9865f7 (commit)
      from  0313947c4cb1ece72d808d35a76e0751080ee083 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit c96deb58149e6b31efd13d45170dc7f70a6109ea
Author: radhika <radhika at curoverse.com>
Date:   Thu Aug 28 16:03:04 2014 -0400

    3714: minor updates from review feedback

diff --git a/apps/workbench/app/views/application/report_issue_popup.js.erb b/apps/workbench/app/views/application/report_issue_popup.js.erb
index a130665..6795c09 100644
--- a/apps/workbench/app/views/application/report_issue_popup.js.erb
+++ b/apps/workbench/app/views/application/report_issue_popup.js.erb
@@ -1,21 +1,16 @@
 $("#report-issue-modal-window").html("<%= escape_javascript(render partial: 'report_issue_popup') %>");
 $("#report-issue-modal-window .modal").modal('show');
 
-// Disable the submit button until the problem description is entered
+// Disable the submit button on modal loading
 $submit = $('#report-issue-submit');
-
-var problem_desc = document.forms["report-issue-form"]["report_issue_text"].value;
-if (problem_desc == null || problem_desc == "") {
-  $submit.attr('disabled', true);
-}
+$submit.attr('disabled', true);
 
 // capture events to enable submit button when applicable
 $('#report_issue_text').bind('input propertychange', function() {
   var problem_desc = document.forms["report-issue-form"]["report_issue_text"].value;
-
-  var trigger = false;
-  if (problem_desc == null || problem_desc == "") {
-    trigger = true;
+  if (problem_desc === null || problem_desc === "") {
+    $submit.attr('disabled', true)
+  } else {
+    $submit.removeAttr('disabled');
   }
-  trigger ? $submit.attr('disabled', true) : $submit.removeAttr('disabled');
 });
diff --git a/apps/workbench/test/integration/report_issue_test.rb b/apps/workbench/test/integration/report_issue_test.rb
index ebedce3..4bf7d57 100644
--- a/apps/workbench/test/integration/report_issue_test.rb
+++ b/apps/workbench/test/integration/report_issue_test.rb
@@ -59,7 +59,7 @@ class ReportIssueTest < ActionDispatch::IntegrationTest
 
       # enter a report text and click on report
       page.find_field('report_issue_text').set 'my test report text'
-        assert page.has_button?('Send problem report'), 'Send problem report button not enabled after entering text'
+      assert page.has_button?('Send problem report'), 'Send problem report button not enabled after entering text'
       click_button 'Send problem report'
 
       # ajax success updated button texts and added footer message

commit 0368e13ebc5a5cfef0c69124cae34301a6d890ff
Merge: 0313947 97473dd
Author: radhika <radhika at curoverse.com>
Date:   Thu Aug 28 15:39:32 2014 -0400

    Merge branch 'master' into 3714-report-issue-issues


-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list