[ARVADOS] updated: 301abeabd5472bdf5795ff42775be325c774c7cc

git at public.curoverse.com git at public.curoverse.com
Mon Aug 18 17:24:31 EDT 2014


Summary of changes:
 apps/workbench/app/controllers/application_controller.rb | 4 ++++
 1 file changed, 4 insertions(+)

       via  301abeabd5472bdf5795ff42775be325c774c7cc (commit)
      from  8917fa82999bdf0020f623db9869abae99930b56 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 301abeabd5472bdf5795ff42775be325c774c7cc
Author: Brett Smith <brett at curoverse.com>
Date:   Mon Aug 18 14:38:57 2014 -0400

    3593: Add explanatory comment about Workbench's user cache.
    
    Refs #3593.

diff --git a/apps/workbench/app/controllers/application_controller.rb b/apps/workbench/app/controllers/application_controller.rb
index b626361..5b9d41e 100644
--- a/apps/workbench/app/controllers/application_controller.rb
+++ b/apps/workbench/app/controllers/application_controller.rb
@@ -436,6 +436,10 @@ class ApplicationController < ActionController::Base
       false  # We may redirect to login, or not, based on the current action.
     else
       session[:arvados_api_token] = params[:api_token]
+      # If we later have trouble contacting the API server, we still want
+      # to be able to render basic user information in the UI--see
+      # render_exception above.  We store that in the session here.  This is
+      # not intended to be used as a general-purpose cache.  See #2891.
       session[:user] = {
         uuid: user.uuid,
         email: user.email,

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list