[ARVADOS] updated: 9bcbc09d57774d068a3867c2630a4b69a59b4812

git at public.curoverse.com git at public.curoverse.com
Fri Apr 11 10:42:10 EDT 2014


Summary of changes:
 services/keep/keep_test.go |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

       via  9bcbc09d57774d068a3867c2630a4b69a59b4812 (commit)
      from  27cb596cfbff2f81210260d49f824bfdbac6dd5d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 9bcbc09d57774d068a3867c2630a4b69a59b4812
Author: Tim Pierce <twp at curoverse.com>
Date:   Fri Apr 11 10:43:56 2014 -0400

    Added todo for TestPutBlockWriteErr (refs #2292)

diff --git a/services/keep/keep_test.go b/services/keep/keep_test.go
index 4a785bd..c1f4e65 100644
--- a/services/keep/keep_test.go
+++ b/services/keep/keep_test.go
@@ -18,7 +18,15 @@ var BAD_BLOCK = []byte("The magic words are squeamish ossifrage.")
 //   * PutBlockFull
 //       - test that PutBlock returns 503 Full if the filesystem is full.
 //         (must mock FreeDiskSpace or Statfs? use a tmpfs?)
-
+//
+//   * PutBlockWriteErr
+//       - test the behavior when Write returns an error.
+//           - Possible solutions: use a small tmpfs and a high
+//             MIN_FREE_KILOBYTES to trick PutBlock into attempting
+//             to write a block larger than the amount of space left
+//           - use an interface to mock ioutil.TempFile with a File
+//             object that always returns an error on write
+//
 // ========================================
 // GetBlock tests.
 // ========================================

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list