[arvados] updated: 2.7.0-6292-g716f55edba

git repository hosting git at public.arvados.org
Tue Apr 9 14:48:00 UTC 2024


Summary of changes:
 .../sharing-dialog/sharing-dialog-component.tsx    | 24 ++++++++++++++++++----
 .../sharing-invitation-form-component.tsx          | 19 +----------------
 2 files changed, 21 insertions(+), 22 deletions(-)

       via  716f55edbae8b8a16e2479e1f0e75619567df051 (commit)
      from  d7cf4c1ec30c7f90f38a9f34c14547c94c081b59 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 716f55edbae8b8a16e2479e1f0e75619567df051
Author: Lisa Knox <lisaknox83 at gmail.com>
Date:   Tue Apr 9 10:47:55 2024 -0400

    21313: moved save button to bottom of share dialog Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox at curii.com>

diff --git a/services/workbench2/src/views-components/sharing-dialog/sharing-dialog-component.tsx b/services/workbench2/src/views-components/sharing-dialog/sharing-dialog-component.tsx
index 5d646c4658..a4800521de 100644
--- a/services/workbench2/src/views-components/sharing-dialog/sharing-dialog-component.tsx
+++ b/services/workbench2/src/views-components/sharing-dialog/sharing-dialog-component.tsx
@@ -89,6 +89,7 @@ export default (props: SharingDialogComponentProps) => {
         className="sharing-dialog"
         fullWidth
         maxWidth='sm'
+        disableBackdropClick={saveEnabled}
         >
         <DialogTitle>
             Sharing settings
@@ -178,13 +179,28 @@ export default (props: SharingDialogComponentProps) => {
                 </>
                 }
                 <Grid item>
+                    <Button onClick={() => {
+                            onSave();
+                        }}
+                        disabled={!saveEnabled}
+                        color='primary'
+                        variant='contained'
+                        size='small'
+                        style={{ marginLeft: '10px' }}
+                        >
+                            Save
+                    </Button>
                     <Button onClick={() => {
                         onClose();
                         setWithExpiration(false);
-                    }}
-                    disabled={saveEnabled}
-                    >
-                        Close
+                        }}
+                        disabled={saveEnabled}
+                        color='primary'
+                        variant='contained'
+                        size='small'
+                        style={{ marginLeft: '10px' }}
+                        >
+                            Close
                     </Button>
                 </Grid>
             </Grid>
diff --git a/services/workbench2/src/views-components/sharing-dialog/sharing-invitation-form-component.tsx b/services/workbench2/src/views-components/sharing-dialog/sharing-invitation-form-component.tsx
index 7e1bf3659e..ca1a83d9c0 100644
--- a/services/workbench2/src/views-components/sharing-dialog/sharing-invitation-form-component.tsx
+++ b/services/workbench2/src/views-components/sharing-dialog/sharing-invitation-form-component.tsx
@@ -48,30 +48,13 @@ const SharingInvitationFormComponent = (props: { onSave: () => void, saveEnabled
 export default SharingInvitationFormComponent;
 
 const StyledSharingInvitationFormComponent = withStyles(styles)(
-    ({ onSave, saveEnabled, classes }: { onSave: () => void, saveEnabled: boolean } & WithStyles<SharingStyles>) =>
+    ({ classes }: { onSave: () => void, saveEnabled: boolean } & WithStyles<SharingStyles>) =>
         <Grid container spacing={8} wrap='nowrap' className={classes.root} >
             <Grid data-cy="invite-people-field" item xs={8}>
                 <InvitedPeopleField />
-                {saveEnabled && 
-                    <Typography 
-                        variant='caption' 
-                        className={classes.shareWarning}
-                        >
-                        You must click &#x1F7A4; to add a participant.
-                    </Typography>}
             </Grid>
             <Grid data-cy="permission-select-field" item xs={4} container wrap='nowrap'>
                 <PermissionSelectField />
-                <IconButton onClick={onSave} disabled={!saveEnabled} color="primary" classes={{
-                    root: classes.addButtonRoot,
-                    colorPrimary: classes.addButtonPrimary,
-                    disabled: classes.addButtonDisabled
-                }}
-                    data-cy='add-invited-people'>
-                    <Tooltip title="Add authorization">
-                        <AddIcon />
-                    </Tooltip>
-                </IconButton>
             </Grid>
         </Grid >);
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list