[arvados] updated: 2.7.0-6362-g4d892bd66c

git repository hosting git at public.arvados.org
Mon Apr 8 01:32:22 UTC 2024


Summary of changes:
 services/workbench2/package.json                        |  2 +-
 .../components/details-attribute/details-attribute.tsx  |  4 ++--
 .../context-menu/actions/file-viewer-action.tsx         |  2 +-
 .../src/views-components/main-app-bar/help-menu.tsx     |  2 +-
 .../repositories-sample-git-dialog.tsx                  |  4 ++--
 .../webdav-s3-dialog/webdav-s3-dialog.tsx               |  4 ++--
 .../src/views/process-panel/process-io-card.tsx         | 10 +++++++---
 .../src/views/process-panel/process-panel-root.tsx      |  1 -
 .../src/views/process-panel/process-resource-card.tsx   |  1 -
 .../virtual-machine-user-panel.tsx                      |  2 +-
 services/workbench2/yarn.lock                           | 17 +++++------------
 11 files changed, 22 insertions(+), 27 deletions(-)

       via  4d892bd66c5d11d8cbde42348099e92da0c21a99 (commit)
       via  9a72938d7fa4786aed241f619476490570933f15 (commit)
       via  e0481ba5073bd1f30d092aeee1a06ef3c635a93b (commit)
      from  0a39d337a1c58d7cbdd51b2f852b84eebc1c68ef (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 4d892bd66c5d11d8cbde42348099e92da0c21a99
Author: Stephen Smith <stephen at curii.com>
Date:   Sun Apr 7 13:55:57 2024 -0400

    21651: Remove unused imports and squelch warnings
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/services/workbench2/src/components/details-attribute/details-attribute.tsx b/services/workbench2/src/components/details-attribute/details-attribute.tsx
index 1f1996424c..019470c026 100644
--- a/services/workbench2/src/components/details-attribute/details-attribute.tsx
+++ b/services/workbench2/src/components/details-attribute/details-attribute.tsx
@@ -96,10 +96,10 @@ export const DetailsAttribute = connect(mapStateToProps)(withStyles(styles)(
                 if (linkUrl[0] === '/') {
                     valueNode = <Link to={linkUrl} className={classes.link}>{uuid}</Link>;
                 } else {
-                    valueNode = <a href={linkUrl} className={classes.link} target='_blank' rel="noopener">{uuid}</a>;
+                    valueNode = <a href={linkUrl} className={classes.link} target='_blank' rel="noopener noreferrer">{uuid}</a>;
                 }
             } else if (link) {
-                valueNode = <a href={link} className={classes.link} target='_blank' rel="noopener">{value}</a>;
+                valueNode = <a href={link} className={classes.link} target='_blank' rel="noopener noreferrer">{value}</a>;
             } else {
                 valueNode = value;
             }
diff --git a/services/workbench2/src/views-components/context-menu/actions/file-viewer-action.tsx b/services/workbench2/src/views-components/context-menu/actions/file-viewer-action.tsx
index 0a77876bac..c4bba3a932 100644
--- a/services/workbench2/src/views-components/context-menu/actions/file-viewer-action.tsx
+++ b/services/workbench2/src/views-components/context-menu/actions/file-viewer-action.tsx
@@ -12,7 +12,7 @@ export const FileViewerAction = (props: any) => {
             style={{ textDecoration: 'none' }}
             href={props.href}
             target="_blank"
-            rel="noopener"
+            rel="noopener noreferrer"
             onClick={props.onClick}>
             <ListItem button>
                 <ListItemIcon>
diff --git a/services/workbench2/src/views-components/main-app-bar/help-menu.tsx b/services/workbench2/src/views-components/main-app-bar/help-menu.tsx
index 1ce2fa1f0f..af76e4f127 100644
--- a/services/workbench2/src/views-components/main-app-bar/help-menu.tsx
+++ b/services/workbench2/src/views-components/main-app-bar/help-menu.tsx
@@ -72,7 +72,7 @@ export const HelpMenu = compose(
                 {
                     links.map(link =>
                         <MenuItem key={link.title}>
-                            <a href={link.link} target="_blank" rel="noopener" className={classes.link}>
+                            <a href={link.link} target="_blank" rel="noopener noreferrer" className={classes.link}>
                                 <ImportContactsIcon className={classes.icon} />
                                 <Typography className={classes.linkTitle}>{link.title}</Typography>
                             </a>
diff --git a/services/workbench2/src/views-components/repositories-sample-git-dialog/repositories-sample-git-dialog.tsx b/services/workbench2/src/views-components/repositories-sample-git-dialog/repositories-sample-git-dialog.tsx
index 7df99300f7..a76ab0f6d0 100644
--- a/services/workbench2/src/views-components/repositories-sample-git-dialog/repositories-sample-git-dialog.tsx
+++ b/services/workbench2/src/views-components/repositories-sample-git-dialog/repositories-sample-git-dialog.tsx
@@ -54,8 +54,8 @@ export const RepositoriesSampleGitDialog = compose(
                         lines={[snippetText(props.data.uuidPrefix)]} />
                     <Typography variant='body1' className={props.classes.spacing}>
                         See also:
-                        <div><a href="https://doc.arvados.org/user/getting_started/ssh-access-unix.html" className={props.classes.link} target="_blank" rel="noopener">SSH access</a></div>
-                        <div><a href="https://doc.arvados.org/user/tutorials/tutorial-firstscript.html" className={props.classes.link} target="_blank" rel="noopener">Writing a Crunch Script</a></div>
+                        <div><a href="https://doc.arvados.org/user/getting_started/ssh-access-unix.html" className={props.classes.link} target="_blank" rel="noopener noreferrer">SSH access</a></div>
+                        <div><a href="https://doc.arvados.org/user/tutorials/tutorial-firstscript.html" className={props.classes.link} target="_blank" rel="noopener noreferrer">Writing a Crunch Script</a></div>
                     </Typography>
                 </DialogContent>
                 <DialogActions>
diff --git a/services/workbench2/src/views-components/webdav-s3-dialog/webdav-s3-dialog.tsx b/services/workbench2/src/views-components/webdav-s3-dialog/webdav-s3-dialog.tsx
index 5aab053d8e..a32044a711 100644
--- a/services/workbench2/src/views-components/webdav-s3-dialog/webdav-s3-dialog.tsx
+++ b/services/workbench2/src/views-components/webdav-s3-dialog/webdav-s3-dialog.tsx
@@ -170,7 +170,7 @@ export const WebDavS3InfoDialog = compose(
 
                     <DetailsAttribute
                         label='Internet address'
-                        value={<a href={winDav.toString()} target="_blank" rel="noopener">{winDav.toString()}</a>}
+                        value={<a href={winDav.toString()} target="_blank" rel="noopener noreferrer">{winDav.toString()}</a>}
                         copyValue={winDav.toString()} />
 
                     <DetailsAttribute
@@ -202,7 +202,7 @@ export const WebDavS3InfoDialog = compose(
                 <TabPanel index={0} value={activeTab}>
                     <DetailsAttribute
                         label='Server'
-                        value={<a href={cyberDavStr} target="_blank" rel="noopener">{cyberDavStr}</a>}
+                        value={<a href={cyberDavStr} target="_blank" rel="noopener noreferrer">{cyberDavStr}</a>}
                         copyValue={cyberDavStr} />
 
                     <DetailsAttribute
diff --git a/services/workbench2/src/views/process-panel/process-io-card.tsx b/services/workbench2/src/views/process-panel/process-io-card.tsx
index 8df4a5e678..5851b145d4 100644
--- a/services/workbench2/src/views/process-panel/process-io-card.tsx
+++ b/services/workbench2/src/views/process-panel/process-io-card.tsx
@@ -27,7 +27,7 @@ import {
     CircularProgress,
 } from "@material-ui/core";
 import { ArvadosTheme } from "common/custom-theme";
-import { CloseIcon, ImageIcon, InputIcon, ImageOffIcon, OutputIcon, MaximizeIcon, UnMaximizeIcon, InfoIcon } from "components/icon/icon";
+import { CloseIcon, InputIcon, OutputIcon, MaximizeIcon, UnMaximizeIcon, InfoIcon } from "components/icon/icon";
 import { MPVPanelProps } from "components/multi-panel-view/multi-panel-view";
 import {
     BooleanCommandInputParameter,
@@ -890,7 +890,7 @@ const KeepUrlPath = withStyles(styles)(({ auth, res, pdh, classes }: KeepUrlProp
                 className={classes.keepLink}
                 href={keepUrlPathNav}
                 target="_blank"
-                rel="noopener"
+                rel="noopener noreferrer"
             >
                 {keepUrlPath || "/"}
             </a>
diff --git a/services/workbench2/src/views/process-panel/process-panel-root.tsx b/services/workbench2/src/views/process-panel/process-panel-root.tsx
index 21f38b0938..c8e93aa3ae 100644
--- a/services/workbench2/src/views/process-panel/process-panel-root.tsx
+++ b/services/workbench2/src/views/process-panel/process-panel-root.tsx
@@ -24,7 +24,6 @@ import { ProcessCmdCard } from "./process-cmd-card";
 import { ContainerRequestResource } from "models/container-request";
 import { OutputDetails, NodeInstanceType } from "store/process-panel/process-panel";
 import { NotFoundView } from 'views/not-found-panel/not-found-panel';
-import { CollectionFile } from 'models/collection-file';
 
 type CssRules = "root";
 
diff --git a/services/workbench2/src/views/process-panel/process-resource-card.tsx b/services/workbench2/src/views/process-panel/process-resource-card.tsx
index d1492ddbf5..d738ed045b 100644
--- a/services/workbench2/src/views/process-panel/process-resource-card.tsx
+++ b/services/workbench2/src/views/process-panel/process-resource-card.tsx
@@ -15,7 +15,6 @@ import {
     Typography,
     Grid,
     Link,
-    Button
 } from '@material-ui/core';
 import { ArvadosTheme } from 'common/custom-theme';
 import {
diff --git a/services/workbench2/src/views/virtual-machine-panel/virtual-machine-user-panel.tsx b/services/workbench2/src/views/virtual-machine-panel/virtual-machine-user-panel.tsx
index ae365ce0a9..f75b36a601 100644
--- a/services/workbench2/src/views/virtual-machine-panel/virtual-machine-user-panel.tsx
+++ b/services/workbench2/src/views/virtual-machine-panel/virtual-machine-user-panel.tsx
@@ -174,7 +174,7 @@ const CardContentWithVirtualMachines = (props: VirtualMachineProps) =>
                         {virtualMachineSendRequest(props)}
                     </div>
                     <div className={props.classes.icon}>
-                        <a href="https://doc.arvados.org/user/getting_started/vm-login-with-webshell.html" target="_blank" rel="noopener" className={props.classes.linkIcon}>
+                        <a href="https://doc.arvados.org/user/getting_started/vm-login-with-webshell.html" target="_blank" rel="noopener noreferrer" className={props.classes.linkIcon}>
                             <Tooltip title="Access VM using webshell">
                                 <HelpIcon />
                             </Tooltip>

commit 9a72938d7fa4786aed241f619476490570933f15
Author: Stephen Smith <stephen at curii.com>
Date:   Sun Apr 7 13:02:10 2024 -0400

    21651: Improve formatting and remove warnings
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/services/workbench2/src/views/process-panel/process-io-card.tsx b/services/workbench2/src/views/process-panel/process-io-card.tsx
index d9e7b87c92..8df4a5e678 100644
--- a/services/workbench2/src/views/process-panel/process-io-card.tsx
+++ b/services/workbench2/src/views/process-panel/process-io-card.tsx
@@ -563,7 +563,11 @@ const ProcessIOPreview = memo(
             data[index+1] && !isMainRow(data[index+1])
         );
 
-        const isMainRow = (param: ProcessIOParameter) => (param && (param.id || param.label && !param.value.secondary));
+        const isMainRow = (param: ProcessIOParameter) => (
+            param &&
+            ((param.id || param.label) &&
+            !param.value.secondary)
+        );
 
         const RenderRow = ({index, style}) => {
             const param = data[index];

commit e0481ba5073bd1f30d092aeee1a06ef3c635a93b
Author: Stephen Smith <stephen at curii.com>
Date:   Sun Apr 7 12:24:18 2024 -0400

    21651: Update browserdb
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/services/workbench2/package.json b/services/workbench2/package.json
index e02fa6b956..103ec4bc57 100644
--- a/services/workbench2/package.json
+++ b/services/workbench2/package.json
@@ -30,7 +30,7 @@
     "babel-core": "6.26.3",
     "babel-runtime": "6.26.0",
     "bootstrap": "^5.3.2",
-    "caniuse-lite": "1.0.30001299",
+    "caniuse-lite": "1.0.30001606",
     "classnames": "2.2.6",
     "cwlts": "1.15.29",
     "date-fns": "^2.28.0",
diff --git a/services/workbench2/yarn.lock b/services/workbench2/yarn.lock
index 7c0e2e6aef..936171f46d 100644
--- a/services/workbench2/yarn.lock
+++ b/services/workbench2/yarn.lock
@@ -3884,7 +3884,7 @@ __metadata:
     babel-core: 6.26.3
     babel-runtime: 6.26.0
     bootstrap: ^5.3.2
-    caniuse-lite: 1.0.30001299
+    caniuse-lite: 1.0.30001606
     classnames: 2.2.6
     cwlts: 1.15.29
     cypress: ^13.6.6
@@ -5174,17 +5174,10 @@ __metadata:
   languageName: node
   linkType: hard
 
-"caniuse-lite at npm:1.0.30001299":
-  version: 1.0.30001299
-  resolution: "caniuse-lite at npm:1.0.30001299"
-  checksum: c770f60ebf3e0cc8043ba4db0ebec12d7a595a6b50cb4437c3c5c55b04de9d2413f711f2828be761e8c37bb46b927a8abe6b199b8f0ffc1a34af0ebdee84be27
-  languageName: node
-  linkType: hard
-
-"caniuse-lite at npm:^1.0.0, caniuse-lite at npm:^1.0.30000981, caniuse-lite at npm:^1.0.30001035, caniuse-lite at npm:^1.0.30001109, caniuse-lite at npm:^1.0.30001541":
-  version: 1.0.30001593
-  resolution: "caniuse-lite at npm:1.0.30001593"
-  checksum: 3e2b19075563c3222101c8d5e6ab2f6e1ba99c3ad03b8d2449f9ee7ed03e9d3dac0b1fb24c129e9a5d89fdde4abb97392280c0abb113c0c60250a2b49f378c60
+"caniuse-lite at npm:1.0.30001606, caniuse-lite at npm:^1.0.0, caniuse-lite at npm:^1.0.30000981, caniuse-lite at npm:^1.0.30001035, caniuse-lite at npm:^1.0.30001109, caniuse-lite at npm:^1.0.30001541":
+  version: 1.0.30001606
+  resolution: "caniuse-lite at npm:1.0.30001606"
+  checksum: fcf2d799d8cb159f4f5b44cd9d2171b18df4bcfdf2770cc8a79c4bb0bc5fd19ed089854223865ced32eacffb60a0a9257c8a1d0ef239e9dc3909f587727e9bb5
   languageName: node
   linkType: hard
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list