[arvados] updated: 2.7.0-6277-g0682477f00
git repository hosting
git at public.arvados.org
Wed Apr 3 15:25:13 UTC 2024
Summary of changes:
services/workbench2/cypress/e2e/process.cy.js | 19 ++++++++++++-------
.../src/views/process-panel/process-io-card.test.tsx | 7 +++++--
2 files changed, 17 insertions(+), 9 deletions(-)
via 0682477f00b9aa7b3b4e27f331de7f3a07b2dabb (commit)
via d9d824fb6d36cc8887e68751cc8813a8b810ba9f (commit)
from 3a7e0c1b7de023461f90d41a1878ec43c3d187a9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 0682477f00b9aa7b3b4e27f331de7f3a07b2dabb
Author: Stephen Smith <stephen at curii.com>
Date: Wed Apr 3 11:23:59 2024 -0400
21508: Make io panel cypress test more robust
Scrolls each checked input into view to advance virtual list and enumerates all
expected params
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>
diff --git a/services/workbench2/cypress/e2e/process.cy.js b/services/workbench2/cypress/e2e/process.cy.js
index 33f820c50e..da220ef619 100644
--- a/services/workbench2/cypress/e2e/process.cy.js
+++ b/services/workbench2/cypress/e2e/process.cy.js
@@ -1408,7 +1408,8 @@ describe("Process tests", function () {
cy.get("[data-cy=process-io-card] h6")
.contains("Input Parameters")
.parents("[data-cy=process-io-card]")
- .within(() => {
+ .within((ctx) => {
+ cy.get(ctx).scrollIntoView();
verifyIOParameter("input_file", null, "Label Description", "input1.tar", "00000000000000000000000000000000+01");
verifyIOParameter("input_file", null, "Label Description", "input1-2.txt", undefined, true);
verifyIOParameter("input_file", null, "Label Description", "input1-3.txt", undefined, true);
@@ -1543,19 +1544,23 @@ describe("Process tests", function () {
cy.get("[data-cy=process-io-card] h6")
.contains("Input Parameters")
.parents("[data-cy=process-io-card]")
- .within(() => {
+ .within((ctx) => {
+ cy.get(ctx).scrollIntoView();
cy.wait(2000);
cy.waitForDom();
- cy.get("tbody tr").each(item => {
- cy.wrap(item).contains("No value");
+
+ testInputs.map((input) => {
+ verifyIOParameter(input.definition.id.split('/').slice(-1)[0], null, null, "No value");
});
});
cy.get("[data-cy=process-io-card] h6")
.contains("Output Parameters")
.parents("[data-cy=process-io-card]")
- .within(() => {
- cy.get("tbody tr").each(item => {
- cy.wrap(item).contains("No value");
+ .within((ctx) => {
+ cy.get(ctx).scrollIntoView();
+
+ testOutputs.map((output) => {
+ verifyIOParameter(output.definition.id.split('/').slice(-1)[0], null, null, "No value");
});
});
});
commit d9d824fb6d36cc8887e68751cc8813a8b810ba9f
Author: Stephen Smith <stephen at curii.com>
Date: Wed Apr 3 10:10:29 2024 -0400
21508: Fix unit test for io panel by mocking autosizer for virtuallist
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>
diff --git a/services/workbench2/src/views/process-panel/process-io-card.test.tsx b/services/workbench2/src/views/process-panel/process-io-card.test.tsx
index 292f6cccf7..ff1ec24de1 100644
--- a/services/workbench2/src/views/process-panel/process-io-card.test.tsx
+++ b/services/workbench2/src/views/process-panel/process-io-card.test.tsx
@@ -15,8 +15,11 @@ import { DefaultCodeSnippet } from "components/default-code-snippet/default-code
import { ProcessOutputCollectionFiles } from './process-output-collection-files';
import { MemoryRouter } from 'react-router-dom';
-
+// Mock collection files component since it just needs to exist
jest.mock('views/process-panel/process-output-collection-files');
+// Mock autosizer for the io panel virtual list
+jest.mock('react-virtualized-auto-sizer', () => ({ children }: any) => children({ height: 600, width: 600 }));
+
configure({ adapter: new Adapter() });
describe('renderers', () => {
@@ -113,7 +116,7 @@ describe('renderers', () => {
it('shows main process with params', () => {
// when
- const parameters = [{id: 'someId', label: 'someLabel', value: [{display: 'someValue'}]}];
+ const parameters = [{id: 'someId', label: 'someLabel', value: {display: 'someValue'}}];
let panel = mount(
<Provider store={store}>
<MuiThemeProvider theme={CustomTheme}>
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list