[arvados] created: 2.7.0-4961-g9850ac96ab

git repository hosting git at public.arvados.org
Tue Oct 10 14:50:09 UTC 2023


        at  9850ac96ab2c11b9776d56beef98d18e4dbdc27d (commit)


commit 9850ac96ab2c11b9776d56beef98d18e4dbdc27d
Author: Lucas Di Pentima <lucas.dipentima at curii.com>
Date:   Tue Oct 10 11:45:29 2023 -0300

    21055: Don't exit when failing to set inotify.max_user_watches.
    
    Docker containers mount procfs as read-only and inherit this setting from
    their host: https://github.com/coder/code-server/issues/628
    
    Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima at curii.com>

diff --git a/lib/install/deps.go b/lib/install/deps.go
index 263f018097..076a4e2b6a 100644
--- a/lib/install/deps.go
+++ b/lib/install/deps.go
@@ -268,7 +268,9 @@ if ! grep -F -- "$add" /etc/sysctl.conf; then
 fi
 `, stdout, stderr)
 		if err != nil {
-			return 1
+			// Just warn instead of fail because this is expected when running
+			// inside Docker.
+			logger.Warnf("couldn't set fs.inotify.max_user_watches value: %w", err)
 		}
 	}
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list