[ARVADOS] created: 2.1.0-1352-g9792171cd

Git user git at public.arvados.org
Thu Sep 16 16:49:00 UTC 2021


        at  9792171cd97a576c34d85291ff64cbc29061fc08 (commit)


commit 9792171cd97a576c34d85291ff64cbc29061fc08
Author: Ward Vandewege <ward at curii.com>
Date:   Thu Sep 16 12:48:12 2021 -0400

    17770: while throttled, do not log that instances are being created when
           they are not.
    
    Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>

diff --git a/lib/dispatchcloud/scheduler/run_queue.go b/lib/dispatchcloud/scheduler/run_queue.go
index e9fc5f902..f729f0dc2 100644
--- a/lib/dispatchcloud/scheduler/run_queue.go
+++ b/lib/dispatchcloud/scheduler/run_queue.go
@@ -78,10 +78,12 @@ tryrun:
 				logger.Trace("overquota")
 				overquota = sorted[i:]
 				break tryrun
-			} else if logger.Info("creating new instance"); sch.pool.Create(it) {
+			} else if sch.pool.Create(it) {
 				// Success. (Note pool.Create works
 				// asynchronously and does its own
-				// logging, so we don't need to.)
+				// logging about the eventual outcome,
+				// so we don't need to.)
+				logger.Info("creating new instance")
 			} else {
 				// Failed despite not being at quota,
 				// e.g., cloud ops throttled.  TODO:

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list