[ARVADOS] updated: cc3857d9fdcd7588af329a9b2452e0ef09eb68a4

Git user git at public.curoverse.com
Mon Oct 31 13:47:48 EDT 2016


Summary of changes:
 COPYING                                            |  14 +-
 .../app/assets/javascripts/work_unit_component.js  |  18 +
 .../app/controllers/work_units_controller.rb       |  54 +++
 apps/workbench/app/models/container.rb             |   2 +-
 apps/workbench/app/models/container_request.rb     |   2 +-
 apps/workbench/app/models/container_work_unit.rb   |   6 +-
 apps/workbench/app/models/job.rb                   |   2 +-
 apps/workbench/app/models/job_task.rb              |   2 +-
 apps/workbench/app/models/pipeline_instance.rb     |   2 +-
 .../app/models/pipeline_instance_work_unit.rb      |   4 +-
 apps/workbench/app/models/proxy_work_unit.rb       |   9 +-
 apps/workbench/app/models/work_unit.rb             |   4 +
 .../pipeline_instances/_show_components.html.erb   |   2 +-
 .../views/work_units/_component_detail.html.erb    |  28 +-
 .../app/views/work_units/_show_child.html.erb      |  29 +-
 .../app/views/work_units/_show_component.html.erb  |  47 +-
 .../app/views/work_units/_show_status.html.erb     |   2 +-
 apps/workbench/config/routes.rb                    |   4 +-
 .../test/controllers/work_units_controller_test.rb |  23 -
 apps/workbench/test/integration/jobs_test.rb       |   2 +-
 apps/workbench/test/integration/work_units_test.rb |  25 +
 build/run-build-docker-jobs-image.sh               |  69 ++-
 build/run-build-packages.sh                        |   2 +-
 build/run-library.sh                               |  12 +-
 .../_container_runtime_constraints.liquid          |   1 +
 docker/jobs/Dockerfile                             |  12 +-
 sdk/cwl/arvados_cwl/__init__.py                    |  30 +-
 sdk/cwl/arvados_cwl/arvcontainer.py                |  13 +-
 sdk/cwl/arvados_cwl/crunch_script.py               |  19 +-
 sdk/cwl/gittaggers.py                              |  38 +-
 sdk/cwl/setup.py                                   |   2 +-
 sdk/python/arvados/arvfile.py                      |  78 ++--
 sdk/python/arvados/commands/put.py                 | 516 +++++++++++++++------
 sdk/python/tests/test_arv_put.py                   | 178 +++----
 .../arvados/v1/containers_controller.rb            |  17 +
 services/api/app/models/container.rb               |  48 +-
 services/api/config/routes.rb                      |   1 +
 .../test/fixtures/api_client_authorizations.yml    |  14 +
 services/api/test/fixtures/collections.yml         |  13 +
 services/api/test/fixtures/containers.yml          |   4 +-
 .../arvados/v1/containers_controller_test.rb       |  19 +
 services/api/test/unit/container_request_test.rb   |   2 +-
 services/api/test/unit/container_test.rb           |  92 +++-
 services/crunch-run/crunchrun.go                   |  24 +-
 services/crunch-run/crunchrun_test.go              |  51 +-
 services/fuse/arvados_fuse/__init__.py             |  14 +
 services/fuse/tests/integration_test.py            |   1 -
 services/fuse/tests/test_mount.py                  |  34 --
 services/fuse/tests/test_token_expiry.py           |  68 +++
 tools/arvbox/bin/arvbox                            |   5 +-
 50 files changed, 1154 insertions(+), 504 deletions(-)
 create mode 100644 apps/workbench/app/assets/javascripts/work_unit_component.js
 mode change 120000 => 100644 sdk/cwl/gittaggers.py
 create mode 100644 services/fuse/tests/test_token_expiry.py

       via  cc3857d9fdcd7588af329a9b2452e0ef09eb68a4 (commit)
       via  120a2268606d73317ab2353d79c3046017300f81 (commit)
       via  62645650fcd451d2ea569c8e55526f6ed0db4fea (commit)
       via  15d8499a8d95abbc4bc2dbbd0bcfd2a4c6666408 (commit)
       via  734335da27f27e2177d3b931b1e5e9e8e83a042f (commit)
       via  5c05b488a1f2318e73780b67f6f654b4a12c32b3 (commit)
       via  ceec074ede6c1e4d8e588ee66dbb6704bf903b68 (commit)
       via  95fc98726d64c71ed0b3a8c2270ee62c1c5d1bb5 (commit)
       via  4c0b3359319e4c778371e3d61368dec6635c3ef2 (commit)
       via  7898b516dfc7e5e9177753d5bcdfc980dc055308 (commit)
       via  0066dc77abc461090fe98bcee7c6e324a5ca43a1 (commit)
       via  07b6eaeada7c10c3efb9b917579c474bd66685b0 (commit)
       via  078bdb166766423e1a423523e5285966aff7ec6b (commit)
       via  6f04833d7837659acdfd01d4fbcf4ae36e8e5f5c (commit)
       via  68463d51530a921dd965075e1721744c75322703 (commit)
       via  40cad1b6c6b969c78fb415ee7be59dac32c45891 (commit)
       via  85292497b7a89b9a0681fc38d307eea26681924c (commit)
       via  8d6ffdf2fba938e7fbb5f128664d828d2669bcfe (commit)
       via  c95fd352d669bc65c0dbc9970ca11291cc933577 (commit)
       via  f830fb6b5a8113aabe6a377cadbb50dc52d5d1e0 (commit)
       via  4304baee8e6cc9483a0cae397149526a0e8356fb (commit)
       via  28e0fb829175415c533ea783d90ade8a39bdb236 (commit)
       via  9ac31a42d4c777c158b2b9a7623194217d7a0772 (commit)
       via  182dd3521c1ea587a94ed2bfa4e1a3e935d493c7 (commit)
       via  4b037a38dbe848a77224dd05dd035736b5d0c0c1 (commit)
       via  7bf89e17945bb6610d6339409a6a411803851434 (commit)
       via  5015b0a3ab4ba407b162abf673d114924ca86c92 (commit)
       via  b4e586171f3fa3eab6b11f4fa4c71c346b2812e7 (commit)
       via  f6288c66e7ae5a2c736e1c9897acedf6d35b0a10 (commit)
       via  4c86081e1ee5149f09f05cd3b77e59fc652d4ab3 (commit)
       via  633781b1ac0f5b23cb43c43d0dda4627c2b9924e (commit)
       via  09a87e19162124ca40cbf13cc90d2aed72f90478 (commit)
       via  b73985d8a0c9173aec57f6a81fe540b2813a5bff (commit)
       via  dfe0ec7bfec3fd72cd40d3962e5c8af08d2413d2 (commit)
       via  6349237efb19ca7fcad94333090d694fda3d4374 (commit)
       via  6362c17d947b16db1e2b71f7a06da9c930ef9778 (commit)
       via  9290528fb9700db4541ebe29c94eda3503f509f4 (commit)
       via  1c7de9d85417202a48ea82409ab390dfcab7f2a5 (commit)
       via  e14484fbba64222e4b32c353e3ea057c6f10acd0 (commit)
       via  4d59e4f59204ff6e278ad7f37b55ead3911412e1 (commit)
       via  617ef14a3f2fac4dad5f699af7000187143ebbe3 (commit)
       via  0e5198142fdba0ce2af6eb2852d45dff46ffb2e2 (commit)
       via  3d984f3ee6182391094ece7e32d61c40be7ba903 (commit)
       via  754913fc3e5037903048863f5545c9512fbf7bfc (commit)
       via  d71020ac08d7b6e84d2d8f8d2c9b22d512144baa (commit)
       via  23a37f77f36717f60884c2b8054a9670b35e611b (commit)
       via  b1158db281c2107b191ddd41dd6b20f32ff04940 (commit)
       via  ed16f0c1f600acd7bab81796ec22fde90ecdfa7f (commit)
       via  17f2b714df870dffc6320173d6a2348243ff7992 (commit)
      from  61b286dcf40fa85319cceb69e16660aebc71b942 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit cc3857d9fdcd7588af329a9b2452e0ef09eb68a4
Author: radhika <radhika at curoverse.com>
Date:   Mon Oct 31 13:47:20 2016 -0400

    10231: add keep_cache_ram to doc

diff --git a/doc/_includes/_container_runtime_constraints.liquid b/doc/_includes/_container_runtime_constraints.liquid
index 06bfb4f..849db42 100644
--- a/doc/_includes/_container_runtime_constraints.liquid
+++ b/doc/_includes/_container_runtime_constraints.liquid
@@ -6,5 +6,6 @@ table(table table-bordered table-condensed).
 |_. Key|_. Type|_. Description|_. Notes|
 |ram|integer|Number of ram bytes to be used to run this process.|Optional. However, a ContainerRequest that is in "Committed" state must provide this.|
 |vcpus|integer|Number of cores to be used to run this process.|Optional. However, a ContainerRequest that is in "Committed" state must provide this.|
+|keep_cache_ram|integer|Number of keep cache bytes to be used to run this process.|Optional.|
 |API|boolean|When set, ARVADOS_API_HOST and ARVADOS_API_TOKEN will be set, and container will have networking enabled to access the Arvados API server.|Optional.|
 |partition|array of strings|Specify the names of one or more compute partitions that may run this container.  If not provided, the system chooses where to run the container.|Optional.|
diff --git a/sdk/cwl/arvados_cwl/arvcontainer.py b/sdk/cwl/arvados_cwl/arvcontainer.py
index c2029b9..ffa9c3e 100644
--- a/sdk/cwl/arvados_cwl/arvcontainer.py
+++ b/sdk/cwl/arvados_cwl/arvcontainer.py
@@ -97,7 +97,8 @@ class ArvadosContainer(object):
 
         runtime_req, _ = get_feature(self, "http://arvados.org/cwl#RuntimeConstraints")
         if runtime_req:
-            runtime_constraints["keep_cache_ram"] = runtime_req["keep_cache"]
+            if "keep_cache" in runtime_req:
+                runtime_constraints["keep_cache_ram"] = runtime_req["keep_cache"]
 
         partition_req, _ = get_feature(self, "http://arvados.org/cwl#PartitionRequirement")
         if partition_req:
diff --git a/services/crunch-run/crunchrun.go b/services/crunch-run/crunchrun.go
index 8e5cdb1..ade40c6 100644
--- a/services/crunch-run/crunchrun.go
+++ b/services/crunch-run/crunchrun.go
@@ -250,6 +250,11 @@ func (runner *ContainerRunner) SetupMounts() (err error) {
 	pdhOnly := true
 	tmpcount := 0
 	arvMountCmd := []string{"--foreground", "--allow-other", "--read-write"}
+
+	if runner.Container.RuntimeConstraints.KeepCacheRAM > 0 {
+		arvMountCmd = append(arvMountCmd, "--file-cache", fmt.Sprintf("%d", runner.Container.RuntimeConstraints.KeepCacheRAM))
+	}
+
 	collectionPaths := []string{}
 	runner.Binds = nil
 
@@ -357,10 +362,6 @@ func (runner *ContainerRunner) SetupMounts() (err error) {
 	}
 	arvMountCmd = append(arvMountCmd, runner.ArvMountPoint)
 
-	if runner.Container.RuntimeConstraints.KeepCacheRAM > 0 {
-		arvMountCmd = append(arvMountCmd, "--file-cache", fmt.Sprintf("%d", runner.Container.RuntimeConstraints.KeepCacheRAM))
-	}
-
 	token, err := runner.ContainerToken()
 	if err != nil {
 		return fmt.Errorf("could not get container token: %s", err)
diff --git a/services/crunch-run/crunchrun_test.go b/services/crunch-run/crunchrun_test.go
index 2fbbb4d..2c71459 100644
--- a/services/crunch-run/crunchrun_test.go
+++ b/services/crunch-run/crunchrun_test.go
@@ -856,7 +856,7 @@ func (s *TestSuite) TestSetupMounts(c *C) {
 
 		err := cr.SetupMounts()
 		c.Check(err, IsNil)
-		c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other", "--read-write", "--mount-tmp", "tmp0", "--mount-by-pdh", "by_id", realTemp + "/keep1", "--file-cache", "512"})
+		c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other", "--read-write", "--file-cache", "512", "--mount-tmp", "tmp0", "--mount-by-pdh", "by_id", realTemp + "/keep1"})
 		sort.StringSlice(cr.Binds).Sort()
 		c.Check(cr.Binds, DeepEquals, []string{realTemp + "/keep1/by_id/59389a8f9ee9d399be35462a0f92541c+53:/keepinp:ro",
 			realTemp + "/keep1/tmp0:/keepout"})

commit 120a2268606d73317ab2353d79c3046017300f81
Merge: 61b286d 6264565
Author: radhika <radhika at curoverse.com>
Date:   Mon Oct 31 12:04:51 2016 -0400

    Merge branch 'master' into 10231-keep-cache-runtime-constraints


-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list