[ARVADOS] updated: 61187968f0e9268430b967ce37a79d9384ec7e3c

git at public.curoverse.com git at public.curoverse.com
Mon Jul 20 10:32:45 EDT 2015


Summary of changes:
 apps/workbench/config/load_config.rb | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

       via  61187968f0e9268430b967ce37a79d9384ec7e3c (commit)
      from  a1e6ebc7e1afc04e8a1de0c0bb8e304eda6ecf2c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 61187968f0e9268430b967ce37a79d9384ec7e3c
Author: Tom Clegg <tom at curoverse.com>
Date:   Mon Jul 20 10:27:06 2015 -0400

    Revert "6362: Change config precedence order."
    
    In Rails 3 (actionpack 3.2.17), changing asset configuration to
    production settings in load_config.rb breaks the rake
    assets:precompile task, e.g., the docker build. This change is still
    desired but needs to be backed out until the bugs are worked out.
    
    This reverts commit 318e3d183c3800863731a20a10f1b8bf9cc82280.
    
    refs #6362

diff --git a/apps/workbench/config/load_config.rb b/apps/workbench/config/load_config.rb
index f14c3ca..51fc81a 100644
--- a/apps/workbench/config/load_config.rb
+++ b/apps/workbench/config/load_config.rb
@@ -23,17 +23,11 @@ ArvadosWorkbench::Application.configure do
     ks.each do |kk|
       cfg = cfg.send(kk)
     end
-    if v.nil? and cfg.respond_to?(k) and !cfg.send(k).nil?
-      # Config is nil in *.yml, but has been set already in
-      # environments/*.rb (or has a Rails default). Don't overwrite
-      # the default/upstream config with nil.
+    if cfg.respond_to?(k.to_sym) and !cfg.send(k).nil?
+      # Config must have been set already in environments/*.rb.
       #
       # After config files have been migrated, this mechanism should
-      # be removed.
-      Rails.logger.warn <<EOS
-DEPRECATED: Inheriting config.#{ks.join '.'} from Rails config.
-            Please move this config into config/application.yml.
-EOS
+      # be deprecated, then removed.
     elsif v.nil?
       # Config variables are not allowed to be nil. Make a "naughty"
       # list, and present it below.

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list